Review main Merged

86354[TASK] Make TYPO3 logo in dashboard, about and installer context aware

Benjamin Franzke CR +2 V +2 Easy +29 −5 updated 09/27/24, 08:14

Commit message

The SVG logo is now styled based on the inherited color scheme
feature [1], that allows embedded documents to use
`@media (prefers-color-scheme: dark)` to detect the value of the
`color-scheme` attribute of the embedding document.
That means it takes the users color-scheme setting (auto, light or dark)
into account.

The previous typo3_orange.svg is kept as-is for the SystemEmail which
is not color-scheme aware.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme#inherited_color_scheme_in_embedded_elements

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Benjamin Franzke uploaded patch set 1 09/27/24, 07:17

  2. core-ci voted on patch set 1 V +1 09/27/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66707

  3. Benjamin Franzke uploaded patch set 2 V +1 09/27/24, 07:30

  4. Benjamin Franzke uploaded patch set 3 09/27/24, 07:35

  5. core-ci voted on patch set 2 V +1 09/27/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66712

  6. Benjamin Kott voted on patch set 3 CR +1 V +1 09/27/24, 07:38

  7. core-ci voted on patch set 3 V +1 09/27/24, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66713

  8. Andreas Kienast voted on patch set 3 CR +2 V +2 09/27/24, 08:14

  9. Andreas Kienast merged patch set 4 09/27/24, 08:14