86360[TASK] Display errors executing the fluid:schema:generate command
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1521
-
Chris Müller uploaded patch set 1 09/27/24, 09:31
-
Chris Müller updated the commit message in patch set 2 09/27/24, 09:47
-
Chris Müller wrote 09/27/24, 09:47
Unset private -
Chris Müller marked it work in progress 09/27/24, 09:48
-
core-ci voted on patch set 2 V -1 09/27/24, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66726
-
Chris Müller uploaded patch set 3
V -110/03/24, 07:47 -
core-ci voted on patch set 3 V -1 10/03/24, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67001
-
Chris Müller uploaded patch set 4
V -110/08/24, 15:42 -
core-ci voted on patch set 4 V -1 10/08/24, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67388
-
Chris Müller uploaded patch set 5
V -110/08/24, 16:11 -
core-ci voted on patch set 5 V +1 10/08/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67392
-
Chris Müller updated the commit message in patch set 6
V +110/08/24, 16:18 -
core-ci voted on patch set 6 V +1 10/08/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67393
-
Chris Müller marked it ready for review 10/08/24, 16:32
-
Garvin Hicking commented on patch set 6 V +1 10/08/24, 17:30
SchemaCommand.php:124It should be "schemata" or "schemas" here if you use "are". Also maybe use past tense instead, because the process is done already? My suggestion would be to maybe just use a "Reported errors" table caption/header, and a final sentence like: "Successfully generated all schemas except those listed with errors." I like the improvement this patch addresses! :) -
Chris Müller uploaded patch set 7
V +110/09/24, 17:43 -
Chris Müller commented on patch set 6 10/09/24, 17:43
SchemaCommand.php:124ReplyDone -
core-ci voted on patch set 7 V +1 10/09/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67460
-
Garvin Hicking voted on patch set 7 CR +1 V +1 10/09/24, 18:03
-
Simon Praetorius voted on patch set 7 CR +2 V +2 10/09/24, 19:06
-
Simon Praetorius merged patch set 8 10/09/24, 19:06