Review main Merged

86360[TASK] Display errors executing the fluid:schema:generate command

Chris Müller CR +2 V +2 Easy +18 −1 updated 10/09/24, 19:06

Commit message

Previously, the command exited with an error when an exception occured
with Fluid 4.0.0. With Fluid 4.0.1 possible errors are caught and collected.

The command now fetches these possible errors and outputs them on the console. This allows extension authors to see those problems which may
hint to technical debts.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1521

  1. Chris Müller uploaded patch set 1 09/27/24, 09:31

  2. Chris Müller updated the commit message in patch set 2 09/27/24, 09:47

  3. Chris Müller wrote 09/27/24, 09:47

    Unset private
  4. Chris Müller marked it work in progress 09/27/24, 09:48

  5. core-ci voted on patch set 2 V -1 09/27/24, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66726

  6. Chris Müller uploaded patch set 3 V -1 10/03/24, 07:47

  7. core-ci voted on patch set 3 V -1 10/03/24, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67001

  8. Chris Müller uploaded patch set 4 V -1 10/08/24, 15:42

  9. core-ci voted on patch set 4 V -1 10/08/24, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67388

  10. Chris Müller uploaded patch set 5 V -1 10/08/24, 16:11

  11. core-ci voted on patch set 5 V +1 10/08/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67392

  12. Chris Müller updated the commit message in patch set 6 V +1 10/08/24, 16:18

  13. core-ci voted on patch set 6 V +1 10/08/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67393

  14. Chris Müller marked it ready for review 10/08/24, 16:32

  15. Garvin Hicking commented on patch set 6 V +1 10/08/24, 17:30

    SchemaCommand.php:124

    It should be "schemata" or "schemas" here if you use "are". Also maybe use past tense instead, because the process is done already? My suggestion would be to maybe just use a "Reported errors" table caption/header, and a final sentence like: "Successfully generated all schemas except those listed with errors." I like the improvement this patch addresses! :)
  16. Chris Müller uploaded patch set 7 V +1 10/09/24, 17:43

  17. Chris Müller commented on patch set 6 10/09/24, 17:43

    SchemaCommand.php:124 Reply

    Done
  18. core-ci voted on patch set 7 V +1 10/09/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67460

  19. Garvin Hicking voted on patch set 7 CR +1 V +1 10/09/24, 18:03

  20. Simon Praetorius voted on patch set 7 CR +2 V +2 10/09/24, 19:06

  21. Simon Praetorius merged patch set 8 10/09/24, 19:06