Review 12.4 Abandoned

86366[BUGFIX] Avoid undefined array key warning in FlexFormTools

Philipp Idler CR 0 V 0 Easy +1 −1 updated 11/22/24, 16:31

Commit message

With #102229 FlexFormTools already got refactored to address
shortcomings of FlexFormTools and its parsing.

However, in 12.4 there is a parsing issue in case a
flexform datasource does not contain a 'sheets' sub-array,
even though theoretically a datasource can be valid
without such 'sheets'.

This patch for now prevents the "Undefined array key" PHP
warning so that the 'proper' error handling can continue.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 57

  1. Philipp Idler uploaded patch set 1 09/27/24, 11:52

  2. core-ci voted on patch set 1 V +1 09/27/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66746

  3. Philipp Idler voted on patch set 1 V +1 09/27/24, 14:47

  4. Garvin Hicking updated the commit message in patch set 2 V +1 09/27/24, 16:50

  5. Garvin Hicking commented on patch set 2 09/27/24, 16:51

    Unresolved

    Thanks for this! I took the liberty to adjust the commit message slightly, hope that's ok for you. I wonder if we would actually need to change the whole processing logic in case a 'sheets' subkey is missing. Then probably the information of the datasource is in another layer of the large array? Did you maybe check if the code can be adjusted so that in case 'sheets' are missing, the array structure gets adapted for it?
  6. core-ci voted on patch set 2 V +1 09/27/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66756

  7. Benni Mack abandoned the change 11/22/24, 16:31

    abandoning this change, we won't do it and the author states we don't need it anymore in the issue.