86367[BUGFIX] Fix AbstractFormViewHelper type hint for identity map
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1114
-
Garvin Hicking uploaded patch set 1 09/27/24, 12:14
-
Simon Praetorius voted on patch set 1 CR +1 V +1 09/27/24, 12:15
-
Garvin Hicking commented on patch set 1 09/27/24, 12:16
@simon@praetorius.me @lolli@schwarzbu.ch thoughts? Another way would be to change 'object' argument to actually be 'object', that would be a breaking change, and also as far as I read the code, an "array" input should be valid. -
core-ci voted on patch set 1 V +1 09/27/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66747
-
Simon Praetorius commented on patch set 1 09/27/24, 12:56
Reply
I'd say: Fix it first like you did. If we want to limit the argument to "object" (which probably makes sense) we should check if any other fallback code could be removed as well. -
Garvin Hicking commented on patch set 1 10/02/24, 16:10
Related: 103162 -
Christian Kuhn updated the commit message in patch set 2
CR +1V +110/08/24, 07:07 -
Christian Kuhn rebased onto patch set 3 10/08/24, 07:07
-
Christian Kuhn voted on patch set 3 CR +1 V +1 10/08/24, 07:08
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 10/08/24, 07:10
-
core-ci voted on patch set 3 V +1 10/08/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67323
-
core-ci voted on patch set 2 V -1 10/08/24, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67322
-
Garvin Hicking voted on patch set 3 CR +2 V +2 10/08/24, 07:41
-
Garvin Hicking merged patch set 4 10/08/24, 07:42