Review main Merged

86369[TASK] Use native types in processDatamap_postProcessFieldArray usages

Torben Hansen CR +2 V +2 Easy +2 −10 updated 11/04/24, 20:53

Commit message

TYPO3 has two implementations of the
`processDatamap_postProcessFieldArray` hook. Both implementations
however currently have a mixup of native types and type annotations.

This change adds native types to both implementations, so type
annotations can be omitted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Torben Hansen uploaded patch set 1 09/29/24, 05:28

  2. core-ci voted on patch set 1 V +1 09/29/24, 05:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66789

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/30/24, 12:46

  4. Guido Schmechel voted on patch set 1 CR +1 09/30/24, 14:16

  5. Garvin Hicking commented on patch set 1 CR +1 V +1 11/04/24, 16:30

    Does this need a breaking change note/rst entry?
  6. Garvin Hicking commented on patch set 1 11/04/24, 16:31

    Reply

    ignore my question, that shouldn't go in here. It's not breaking of course because the hook is "custom code" and not API.
  7. Benni Mack voted on patch set 1 CR +2 V +2 11/04/24, 20:52

  8. Benni Mack merged patch set 2 11/04/24, 20:53