Review main Merged

86370[BUGFIX] Apply `LIMIT` after overlay in Extbase queries for Workspace

Enes Akgün CR +2 V +2 Normal +69 −18 updated 04/01/25, 12:54

Commit message

In the workspace preview, the SQL `LIMIT` clause was applied too
early in Extbase queries, resulting in incomplete records being shown.
This fix ensures that the `LIMIT` is applied after the overlay process
has been executed, allowing all relevant records to be correctly
included in the preview.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 1623

  1. Enes Akgün uploaded patch set 1 09/29/24, 11:50

  2. core-ci voted on patch set 1 V +1 09/29/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66794

  3. Stefan Bürk commented on patch set 1 CR -1 09/29/24, 14:47

    I'd say we should cover this with at least one tests (showing it is broken and that the change fixes it). Can you add one or more tests for this please ? (Thus the -1)
    Commit message line length (max 72 chars) exceeded. Please reformat commit message.
  4. Stefan Bürk commented on patch set 1 09/29/24, 14:47

    Thanks for providing this bugfix
  5. Enes Akgün uploaded patch set 2 CR -1 V +1 09/29/24, 19:54

  6. core-ci voted on patch set 2 V +1 09/29/24, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66815

  7. Enes Akgün commented on patch set 2 09/29/24, 20:02

    Reply

    Done
    Thanks, I’ve added a test to cover the issue

    Reply

    Done
  8. Joerg Kummer commented on patch set 2 V +1 10/16/24, 04:44

    Reply

    > Thanks, I’ve added a test to cover the issue
  9. Georg Ringer commented on patch set 2 10/16/24, 06:31

    Typo3DbBackend.php:495

    variable should be named $countOverlaidRows I guess
  10. Enes Akgün uploaded patch set 3 V +1 10/20/24, 20:55

  11. core-ci voted on patch set 3 V +1 10/20/24, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68266

  12. Enes Akgün commented on patch set 3 10/20/24, 21:05

    Typo3DbBackend.php:495 Reply

    Done
  13. Enes Akgün rebased onto patch set 4 V +1 03/25/25, 20:21

  14. core-ci voted on patch set 4 V +1 03/25/25, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76307

  15. Benni Mack uploaded patch set 5 V +1 03/28/25, 22:34

  16. Benni Mack uploaded patch set 6 03/28/25, 22:40

  17. core-ci voted on patch set 5 V +1 03/28/25, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76614

  18. core-ci voted on patch set 6 V +1 03/28/25, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76615

  19. Benni Mack voted on patch set 6 CR +1 V +1 03/28/25, 22:49

  20. Benni Mack uploaded patch set 7 CR +1 V +1 03/31/25, 15:36

  21. core-ci voted on patch set 7 V +1 03/31/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76725

  22. Stefan Bürk voted on patch set 7 CR +2 V +2 04/01/25, 12:26

  23. Stefan Bürk merged patch set 8 04/01/25, 12:54