86371[TASK] Mitigate `PHP 8.4.0-RC1` breaking changes
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+1 −1
- typo3/sysext/core/Classes/Error/ErrorHandler.php+2 −1
- typo3/sysext/core/Classes/LinkHandling/TypoLinkCodecService.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/CsvUtility.php+2 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+6 −3
- typo3/sysext/core/Resources/PHP/DeprecatedConstants.php5new+23 −0
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Error/ErrorHandlerTest.php+4 −2
- typo3/sysext/core/composer.json+4 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+2 −1
- composer.json+1 −0
- composer.lock+5 −4
Review log 1725
-
Stefan Bürk uploaded patch set 1 09/29/24, 14:31
-
core-ci voted on patch set 1 V -1 09/29/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66795
-
Stefan Bürk uploaded patch set 2
V -109/29/24, 15:11 -
core-ci voted on patch set 2 V -1 09/29/24, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66800
-
Stefan Bürk uploaded patch set 3
V -109/29/24, 15:28 -
core-ci voted on patch set 3 V -1 09/29/24, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66803
-
core-ci commented on patch set 3 09/29/24, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66803
-
Stefan Bürk uploaded patch set 4
V -109/29/24, 16:18 -
Stefan Bürk updated the commit message in patch set 5 09/29/24, 16:20
-
core-ci voted on patch set 4 V -1 09/29/24, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66805
-
core-ci voted on patch set 5 V -1 09/29/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66806
-
Stefan Bürk uploaded patch set 6
V -109/29/24, 16:32 -
Garvin Hicking updated the commit message in patch set 7 09/29/24, 16:33
-
Garvin Hicking commented on patch set 7 09/29/24, 16:37
-
core-ci voted on patch set 7 V +1 09/29/24, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66808
-
Stefan Bürk uploaded patch set 8
V +109/29/24, 16:43 -
Stefan Bürk commented on patch set 8 09/29/24, 16:43
DeprecatedConstants.php:20ReplyDone -
core-ci voted on patch set 8 V +1 09/29/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66809
-
Garvin Hicking voted on patch set 8 CR +1 V +1 09/29/24, 17:22
-
Anja Leichsenring voted on patch set 8 CR +1 V +1 09/29/24, 17:27
-
Stefan Bürk voted on patch set 8 CR +2 V +2 09/29/24, 17:49
-
Stefan Bürk merged patch set 9 09/29/24, 17:49
-
Andreas Kienast commented on patch set 9 09/30/24, 08:25
DeprecatedConstants.php:19So we're trading a deprecated constant with a deprecated constant? -
Benjamin Franzke commented on patch set 9 09/30/24, 08:41
DeprecatedConstants.php:19ReplyI'd suggest to just use `2048` in code with a clear explanation why we do that, like: ``` @todo: remove 2048 (deprecated E_STRICT) in v14, as this value is no longer used by PHP and only here for possible custom PHP extensions that sill use it. See https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant ``` -
Benjamin Franzke commented on patch set 9 10/03/24, 16:54
DeprecatedConstants.php:19Reply
DeprecatedConstants.php:20