Review main Abandoned

86373[TASK] Explicitly provide all `fgetcsv()` arguments

Stefan Bürk CR 0 V 0 Easy +1 −1 updated 09/29/24, 15:07

Commit message

With [1] the 5th parameter `$escape` of `fgetcsv()` must
be provided either positional or using named arguments or a
E_DEPRECATED will be emitted since `PHP 8.4.0 RC1` [2].

This change provide now all five parameter for `fgetcsv()`
calls and thus using the positional approach to allow easier
backporting to older TYPO3 version where named arguements are
not usable.

[1] https://github.com/php/php-src/pull/15569
[2] https://github.com/php/php-src/blob/ebee8df27ed/UPGRADING#L617-L622

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 23

  1. Stefan Bürk uploaded patch set 1 09/29/24, 14:31

  2. core-ci voted on patch set 1 V -1 09/29/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66797

  3. Stefan Bürk abandoned the change 09/29/24, 15:07

    Integrated into #105155