Review main Abandoned

86374[TASK] Mitigate deprecated php constant `E_STRICT` usage

Stefan Bürk CR 0 V 0 Easy +16 −8 updated 09/29/24, 16:15

Commit message

Since PHP 8.4.0 RC1 the natice error constant `E_STRICT`
has been deprecated and emits a E_DEPRECATED message and
thus failing TYPO3 Core tests [1][2].

In contrast to PHP, which postulated that this constant is not
really in use and 3rd party code should not emit this usually,
TYPO3 cannot simply remove the usage directly due to different
reasons.

This change takes care of the deprecated constanst by replacing
direct usage with the integer value `2048`, for example in places
where it needs to be set or used as mapping value like for log
message creation or display transformation. That keeps the working
state while avoding the deprecation notice.

[1] https://github.com/php/php-src/blob/ebee8df27edf7/UPGRADING#L47-L49
[2] https://github.com/php/php-src/pull/13053

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 47

  1. Stefan Bürk uploaded patch set 1 09/29/24, 14:31

  2. core-ci voted on patch set 1 V -1 09/29/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66798

  3. Stefan Bürk rebased onto patch set 2 V -1 09/29/24, 15:11

  4. core-ci voted on patch set 2 V -1 09/29/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66802

  5. Stefan Bürk uploaded patch set 3 09/29/24, 15:28

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  6. core-ci voted on patch set 3 V -1 09/29/24, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66804

  7. Stefan Bürk abandoned the change 09/29/24, 16:15

    Integrated into #105155