86382[TASK] Remove E_STRICT_DEPRECATED constant
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Error/ErrorHandler.php+4 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+6 −6
- typo3/sysext/core/Resources/PHP/DeprecatedConstants.phpdeleted+0 −23
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Error/ErrorHandlerTest.php1+5 −4
- typo3/sysext/core/composer.json+0 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+4 −2
- composer.json+0 −1
Review log 910
-
Benjamin Franzke uploaded patch set 1 09/30/24, 08:55
-
Stefan Bürk commented on patch set 1 CR -1 09/30/24, 08:57
+ 12.4 & 11.5 -
Benjamin Franzke updated the commit message in patch set 2
CR -109/30/24, 08:57 -
Benjamin Franzke commented on patch set 2 09/30/24, 08:57
Reply
ah, thanks! -
Benjamin Franzke updated the commit message in patch set 3 09/30/24, 09:00
-
Garvin Hicking commented on patch set 3 CR +1 V +1 09/30/24, 09:02
ErrorHandlerTest.php:47This makes the occurence well findable later on, which way my main gripe with hardcoding '2048' before. Good solution! -
core-ci voted on patch set 3 V +1 09/30/24, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66843
-
Stefan Bürk voted on patch set 3 CR +1 V +1 09/30/24, 09:13
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 09/30/24, 09:44
-
Benjamin Franzke merged patch set 4 09/30/24, 09:44