Review main Merged

86382[TASK] Remove E_STRICT_DEPRECATED constant

Benjamin Franzke CR +2 V +2 Normal +23 −41 updated 09/30/24, 09:44

Commit message

We can not deprecate a constant and use it at the same time.
We basically traded a deprecated constant with a new deprecated
constant. Therefore this intermediate constant (added without being
released yet in #105155) is removed again and replaced by a plain value.

It's too likely that this constant is used by 3rd party code
(or dependencies like typo3/testing-framework), which then makes
it hard to remove this constant again (despite being deprecated).

Also defining an own constant – that looks like an official PHP
constant – into the global space, has caused immediate confusions
which we want to avoid by using a scalar value + comment.

The reason (possible 3rd party extensions that may still trigger
this error) why this is kept (and not just removed) is also added
to all usages now.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 910

  1. Benjamin Franzke uploaded patch set 1 09/30/24, 08:55

  2. Stefan Bürk commented on patch set 1 CR -1 09/30/24, 08:57

    + 12.4 & 11.5
  3. Benjamin Franzke updated the commit message in patch set 2 CR -1 09/30/24, 08:57

  4. Benjamin Franzke commented on patch set 2 09/30/24, 08:57

    Reply

    ah, thanks!
  5. Benjamin Franzke updated the commit message in patch set 3 09/30/24, 09:00

  6. Garvin Hicking commented on patch set 3 CR +1 V +1 09/30/24, 09:02

    ErrorHandlerTest.php:47

    This makes the occurence well findable later on, which way my main gripe with hardcoding '2048' before. Good solution!
  7. core-ci voted on patch set 3 V +1 09/30/24, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66843

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 09/30/24, 09:13

  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 09/30/24, 09:44

  10. Benjamin Franzke merged patch set 4 09/30/24, 09:44