Review main Merged

86385[TASK] FormEngine: do not return a value in `validateField()`

Andreas Kienast CR +2 V +2 Easy +6 −40 updated 12/11/24, 08:47

Commit message

The FormEngine validation method `validateField()` previously returned a
value, which does not make much sense in the method's scope.

There is an actual value modification going on, but the code copied the
value into a separate variable, which was returned. In simple words:
input === output.

This is even more questionable and revealed a no-op branch regarding
FlexForm sections, which has been removed as well.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1218

  1. Andreas Kienast uploaded patch set 1 09/30/24, 09:31

  2. Andreas Kienast commented on patch set 1 09/30/24, 09:32

    form-engine-validation.ts:528

    This is only the case for password fields, this needs another solution.
  3. core-ci voted on patch set 1 V +1 09/30/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66846

  4. Andreas Kienast uploaded patch set 2 V +1 09/30/24, 10:08

  5. core-ci voted on patch set 2 V -1 09/30/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66848

  6. Andreas Kienast uploaded patch set 3 V -1 11/20/24, 12:22

  7. Andreas Kienast commented on patch set 3 11/20/24, 12:23

    form-engine-validation.ts:528 Reply

    Done
  8. core-ci voted on patch set 3 V +1 11/20/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69790

  9. Andreas Kienast rebased onto patch set 4 V +1 11/20/24, 15:46

  10. Andreas Kienast updated the commit message in patch set 5 11/20/24, 15:51

  11. core-ci voted on patch set 4 V +1 11/20/24, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69807

  12. core-ci voted on patch set 5 V +1 11/20/24, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69810

  13. Andreas Kienast uploaded patch set 6 V +1 11/21/24, 09:13

  14. core-ci voted on patch set 6 V +1 11/21/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69902

  15. Christian Kuhn voted on patch set 6 CR +1 V +1 11/21/24, 10:43

  16. Benni Mack voted on patch set 6 CR +1 V +1 12/10/24, 18:16

  17. Andreas Kienast voted on patch set 6 CR +2 V +2 12/11/24, 08:46

  18. Andreas Kienast merged patch set 7 12/11/24, 08:47