Review main Merged

86386[TASK] Deprecate INCLUDE_TYPOSCRIPT syntax

Christian Kuhn CR +2 V +2 Normal +197 −22 updated 10/07/24, 14:11

Commit message

The @import syntax has been introduced with TYPO3 v9.
With the TypoScript parser rewrite in v12, some last
todos have been ruled out in this area.
There are some good reasons to finally phase out
`<INCLUDE_TYPOSCRIPT:`, the deprecation ReST gives
further information.
The patch adds an active trigger_error() when the
parser hits a `<INCLUDE_TYPOSCRIPT:` statement and
marks all related handling code as deprecated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 21

Show 1 more file

Review log 2130

Show 35 earlier messages
  1. Christian Kuhn uploaded patch set 1 09/30/24, 11:07

  2. core-ci voted on patch set 1 V -1 09/30/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66851

  3. Christian Kuhn uploaded patch set 2 V -1 09/30/24, 11:43

  4. core-ci voted on patch set 2 V -1 09/30/24, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66852

  5. Christian Kuhn uploaded patch set 3 V -1 09/30/24, 13:15

  1. Christian Kuhn uploaded patch set 4 09/30/24, 13:24

  2. core-ci voted on patch set 3 V -1 09/30/24, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66855

  3. core-ci voted on patch set 4 V +1 09/30/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66856

  4. Christian Kuhn commented on patch set 4 CR -1 09/30/24, 15:11

    working on a good .rst file explaining the why and how in detail now.
  5. Christian Kuhn uploaded patch set 5 CR -1 V +1 10/02/24, 09:41

  6. Christian Kuhn uploaded patch set 6 10/02/24, 09:45

  7. core-ci voted on patch set 5 V -1 10/02/24, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66962

  8. core-ci voted on patch set 6 V +1 10/02/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66963

  9. Christian Kuhn commented on patch set 6 CR -1 10/02/24, 10:49

    will apply some further .rst finetuning.
  10. Christian Kuhn uploaded patch set 7 CR -1 V +1 10/02/24, 11:07

  11. Christian Kuhn updated the commit message in patch set 8 10/02/24, 11:08

  12. core-ci voted on patch set 7 V +1 10/02/24, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66972

  13. core-ci voted on patch set 8 V +1 10/02/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66973

  14. Simon Schaufelberger voted on patch set 8 CR +1 10/02/24, 12:05

  15. Chris Müller commented on patch set 8 10/02/24, 17:11

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:102

    Shouldn't it be "DIR:EXT:..." instead?
  16. Benni Mack voted on patch set 8 CR +1 V +1 10/04/24, 11:04

  17. Christian Kuhn uploaded patch set 9 CR +1 V +1 10/07/24, 13:39

  18. Christian Kuhn commented on patch set 8 10/07/24, 13:39

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:102 Reply

    Done
  19. Simon Schaufelberger voted on patch set 9 CR +1 10/07/24, 13:50

  20. core-ci voted on patch set 9 V +1 10/07/24, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67239

  21. Stefan Bürk voted on patch set 9 CR +1 V +1 10/07/24, 14:08

  22. Benni Mack voted on patch set 9 CR +1 V +1 10/07/24, 14:10

  23. Anja Leichsenring voted on patch set 9 CR +1 V +1 10/07/24, 14:10

  24. Christian Kuhn voted on patch set 9 CR +2 V +2 10/07/24, 14:11

  25. Christian Kuhn merged patch set 10 10/07/24, 14:11