Review main Merged

86388[TASK] Update css-tree to v3.0

Benjamin Franzke CR +2 V +2 Normal +51 −19 updated 11/15/24, 16:48

Commit message

Most notable features that are of interest, css-tree v3 added support
for:

 * @container at-rule
 * @starting-style at-rule
 * @scope at-rule
 * @position-try at-rule
 * @layer at-rule
 * layer, layer() and supports() in the @media at-rule
   (according to the @import rule in Cascading and Inheritance 5)

Executed commands:

  npm install --save css-tree@3.0.1
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1116

  1. Benjamin Franzke uploaded patch set 1 10/01/24, 07:18

  2. core-ci voted on patch set 1 V -1 10/01/24, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66877

  3. core-ci voted on patch set 1 V +1 10/01/24, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66877

  4. Oliver Hader updated the commit message in patch set 2 V +1 10/18/24, 14:02

  5. Oliver Hader rebased onto patch set 3 11/15/24, 09:10

  6. core-ci voted on patch set 3 V +1 11/15/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69464

  7. Benni Mack updated the commit message in patch set 4 V +1 11/15/24, 09:27

  8. core-ci voted on patch set 4 V +1 11/15/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69466

  9. Benni Mack voted on patch set 4 CR +1 V +1 11/15/24, 09:49

  10. Andreas Kienast commented on patch set 4 CR -1 11/15/24, 10:34

    on it
  11. Andreas Kienast uploaded patch set 5 CR +1 V +1 11/15/24, 10:37

  12. Andreas Kienast voted on patch set 5 CR +1 V +1 11/15/24, 10:38

  13. core-ci voted on patch set 5 V +1 11/15/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69470

  14. Benni Mack voted on patch set 5 CR +1 V +1 11/15/24, 16:25

  15. Benjamin Franzke voted on patch set 5 CR +2 V +2 11/15/24, 16:26

  16. Benjamin Franzke merged patch set 6 11/15/24, 16:48