86390[TASK] Add filter to the site settings editor
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Lina Wolf +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Lina Wolf +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/Sass/component/_settings.scss+1 −0
- Build/Sources/TypeScript/backend/settings/editor.ts+125 −9
- typo3/sysext/backend/Resources/Private/Language/locallang_sitesettings.xlf+15 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.js+69 −27
Review log 68
-
Benjamin Franzke uploaded patch set 1 10/01/24, 09:29
-
core-ci voted on patch set 1 V -1 10/01/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66882
-
Benjamin Franzke uploaded patch set 2
V -110/01/24, 10:11 -
core-ci voted on patch set 2 V +1 10/01/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66883
-
Lina Wolf commented on patch set 2 CR +1 V +1 10/01/24, 14:35
I tested this with the custom doc team extensions and with the site settings from my ticket and it worked fine. As far as I can tell codce looks good, I am not a frontend developer however. -
Benni Mack commented on patch set 2 CR +1 V +1 10/02/24, 07:42
thanks! -
Benjamin Franzke voted on patch set 2 CR +2 V +2 10/02/24, 08:13
-
Benjamin Franzke merged patch set 3 10/02/24, 08:14