Review main Merged

86390[TASK] Add filter to the site settings editor

Benjamin Franzke CR +2 V +2 Normal +211 −37 updated 10/02/24, 08:14

Commit message

A search term based filter is added to the site settings editor that
allows that filter by setting value, label, description or identifier.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Lina Wolf +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Lina Wolf +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 68

  1. Benjamin Franzke uploaded patch set 1 10/01/24, 09:29

  2. core-ci voted on patch set 1 V -1 10/01/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66882

  3. Benjamin Franzke uploaded patch set 2 V -1 10/01/24, 10:11

  4. core-ci voted on patch set 2 V +1 10/01/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66883

  5. Lina Wolf commented on patch set 2 CR +1 V +1 10/01/24, 14:35

    I tested this with the custom doc team extensions and with the site settings from my ticket and it worked fine. As far as I can tell codce looks good, I am not a frontend developer however.
  6. Benni Mack commented on patch set 2 CR +1 V +1 10/02/24, 07:42

    thanks!
  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/02/24, 08:13

  8. Benjamin Franzke merged patch set 3 10/02/24, 08:14