86392[TASK] Show site set dependency errors in site modules
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 19
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+1 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_sitesettings.xlf+2 −2
- typo3/sysext/backend/Resources/Private/Partials/SiteManagement/InvalidSets.html2new+33 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Edit.html+2 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html4+4 −1
- typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Edit.html+7 −6
- typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Overview.html2+15 −10
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+28 −2
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+27 −0
- typo3/sysext/core/Classes/Site/Entity/Site.php+6 −0
- typo3/sysext/core/Classes/Site/Set/InvalidSettingsDefinitionsException.phpnew+38 −0
- typo3/sysext/core/Classes/Site/Set/InvalidSettingsException.phpnew+38 −0
- typo3/sysext/core/Classes/Site/Set/SetCollector.php+20 −0
- typo3/sysext/core/Classes/Site/Set/SetError.phpnew+36 −0
- typo3/sysext/core/Classes/Site/Set/SetRegistry.php+46 −11
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+15 −4
- typo3/sysext/core/Classes/Site/TcaSiteSetCollector.php+44 −3
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+15 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+1 −0
Review log 2132
Show 47 earlier messages
-
Benjamin Franzke uploaded patch set 1 10/01/24, 12:41
-
core-ci voted on patch set 1 V -1 10/01/24, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66891
-
Benjamin Franzke uploaded patch set 2
V -110/01/24, 13:54 -
core-ci voted on patch set 2 V -1 10/01/24, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66898
-
Benjamin Franzke uploaded patch set 3
V -110/01/24, 14:04 -
core-ci voted on patch set 3 V +1 10/01/24, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66899
-
Benjamin Franzke uploaded patch set 4
V +110/01/24, 19:07
-
core-ci voted on patch set 4 V +1 10/01/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66914
-
Benjamin Franzke uploaded patch set 5
V +110/01/24, 19:13 -
core-ci voted on patch set 5 V +1 10/01/24, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66915
-
Benjamin Franzke uploaded patch set 6
V +110/04/24, 06:42 -
Benjamin Franzke uploaded patch set 7 10/04/24, 06:55
-
core-ci voted on patch set 6 V +1 10/04/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67053
-
core-ci voted on patch set 7 V +1 10/04/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67056
-
Andreas Kienast commented on patch set 7 10/04/24, 12:50
Overview.html:32`hideIcon` is not used in the referenced partial. -
Benjamin Franzke uploaded patch set 8
V +110/04/24, 12:57 -
Benjamin Franzke commented on patch set 8 10/04/24, 12:57
Overview.html:120Replythx, that was a left over.Overview.html:32Replythx, that was a left over. -
core-ci voted on patch set 8 V +1 10/04/24, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67090
-
Benjamin Franzke updated the commit message in patch set 9
V +110/07/24, 12:46 -
core-ci voted on patch set 9 V +1 10/07/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67233
-
Simon Schaufelberger commented on patch set 9 10/07/24, 15:02
InvalidSets.html:10please use just one empty line hereOverview.html:119how about using some margin-top instead? -
Benjamin Franzke uploaded patch set 10
V +110/07/24, 15:28 -
Benjamin Franzke commented on patch set 10 10/07/24, 15:28
InvalidSets.html:10ReplyDoneOverview.html:119ReplyDone -
core-ci voted on patch set 10 V +1 10/07/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67254
-
Georg Ringer voted on patch set 10 CR +1 V +1 10/07/24, 17:52
-
Simon Schaufelberger uploaded patch set 11
CR +1V +110/07/24, 18:54 -
core-ci voted on patch set 11 V +1 10/07/24, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67283
-
Simon Schaufelberger voted on patch set 11 CR +1 V +1 10/07/24, 19:02
-
Andreas Kienast voted on patch set 11 CR +1 V +1 10/10/24, 18:00
-
Benjamin Kott voted on patch set 11 CR +1 V +1 10/11/24, 06:46
-
Benjamin Franzke voted on patch set 11 CR +2 V +2 10/11/24, 08:04
-
Benjamin Franzke merged patch set 12 10/11/24, 08:04
Overview.html:120