Review main Merged

86392[TASK] Show site set dependency errors in site modules

Benjamin Franzke CR +2 V +2 Hard +378 −40 updated 10/11/24, 08:04

Commit message

Invalid site dependencies have been logged as errors
by the site registry since their introduction.
But these logs are not very introspectable and the backend modules
display the site as if nothing is broken.

To give integrators more information about errors, the invalid
set dependencies and settings errors are now collected and
displayed in site configuration overview and site settings editor.

Also adapt some labels to use consistent capitalization.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 19

Review log 2132

Show 47 earlier messages
  1. Benjamin Franzke uploaded patch set 1 10/01/24, 12:41

  2. core-ci voted on patch set 1 V -1 10/01/24, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66891

  3. Benjamin Franzke uploaded patch set 2 V -1 10/01/24, 13:54

  4. core-ci voted on patch set 2 V -1 10/01/24, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66898

  5. Benjamin Franzke uploaded patch set 3 V -1 10/01/24, 14:04

  6. core-ci voted on patch set 3 V +1 10/01/24, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66899

  7. Benjamin Franzke uploaded patch set 4 V +1 10/01/24, 19:07

  1. core-ci voted on patch set 4 V +1 10/01/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66914

  2. Benjamin Franzke uploaded patch set 5 V +1 10/01/24, 19:13

  3. core-ci voted on patch set 5 V +1 10/01/24, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66915

  4. Benjamin Franzke uploaded patch set 6 V +1 10/04/24, 06:42

  5. Benjamin Franzke uploaded patch set 7 10/04/24, 06:55

  6. core-ci voted on patch set 6 V +1 10/04/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67053

  7. core-ci voted on patch set 7 V +1 10/04/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67056

  8. Andreas Kienast commented on patch set 7 10/04/24, 12:50

    Overview.html:120

    `hideIcon` is not used in the referenced partial.

    Overview.html:32

    `hideIcon` is not used in the referenced partial.
  9. Benjamin Franzke uploaded patch set 8 V +1 10/04/24, 12:57

  10. Benjamin Franzke commented on patch set 8 10/04/24, 12:57

    Overview.html:120 Reply

    thx, that was a left over.

    Overview.html:32 Reply

    thx, that was a left over.
  11. core-ci voted on patch set 8 V +1 10/04/24, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67090

  12. Benjamin Franzke updated the commit message in patch set 9 V +1 10/07/24, 12:46

  13. core-ci voted on patch set 9 V +1 10/07/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67233

  14. Simon Schaufelberger commented on patch set 9 10/07/24, 15:02

    InvalidSets.html:10

    please use just one empty line here

    Overview.html:119

    how about using some margin-top instead?
  15. Benjamin Franzke uploaded patch set 10 V +1 10/07/24, 15:28

  16. Benjamin Franzke commented on patch set 10 10/07/24, 15:28

    InvalidSets.html:10 Reply

    Done

    Overview.html:119 Reply

    Done
  17. core-ci voted on patch set 10 V +1 10/07/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67254

  18. Georg Ringer voted on patch set 10 CR +1 V +1 10/07/24, 17:52

  19. Simon Schaufelberger uploaded patch set 11 CR +1 V +1 10/07/24, 18:54

  20. core-ci voted on patch set 11 V +1 10/07/24, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67283

  21. Simon Schaufelberger voted on patch set 11 CR +1 V +1 10/07/24, 19:02

  22. Andreas Kienast voted on patch set 11 CR +1 V +1 10/10/24, 18:00

  23. Benjamin Kott voted on patch set 11 CR +1 V +1 10/11/24, 06:46

  24. Benjamin Franzke voted on patch set 11 CR +2 V +2 10/11/24, 08:04

  25. Benjamin Franzke merged patch set 12 10/11/24, 08:04