86393[DOCS] Revise Breaking: #100229 - Convert JSConfirmation to a BitSet
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Chris Müller +1
- David Bruchmann +1
-
Verified V +2 Done
- Garvin Hicking +2
- Chris Müller +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1417
-
Thomas Hohn uploaded patch set 1 10/01/24, 14:40
-
Thomas Hohn updated the commit message in patch set 2 10/01/24, 14:43
-
core-ci voted on patch set 1 V +1 10/01/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66900
-
core-ci voted on patch set 2 V +1 10/01/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66901
-
David Bruchmann commented on patch set 2 10/01/24, 15:53
Breaking-100229-ConvertJSConfirmationToBitSet.rst:43And here -
Thomas Hohn commented on patch set 2 10/01/24, 16:12
Breaking-100229-ConvertJSConfirmationToBitSet.rst:42ReplyThis is in the affected partBreaking-100229-ConvertJSConfirmationToBitSet.rst:43ReplyThis is in the affected part -
David Bruchmann commented on patch set 2 10/01/24, 16:40
Breaking-100229-ConvertJSConfirmationToBitSet.rst:42ReplyDoneBreaking-100229-ConvertJSConfirmationToBitSet.rst:43ReplyDoneBreaking-100229-ConvertJSConfirmationToBitSet.rst:63and where `JSConfirmation::compare()` is used, replace the namespace from :php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation` to :php:`\TYPO3\CMS\Core\Authentication\JsConfirmation` -
Thomas Hohn commented on patch set 2 10/01/24, 16:47
Breaking-100229-ConvertJSConfirmationToBitSet.rst:63ReplyAcknowledged -
Thomas Hohn uploaded patch set 3
V +110/01/24, 16:48 -
core-ci voted on patch set 3 V +1 10/01/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66911
-
David Bruchmann voted on patch set 3 CR +1 10/01/24, 16:58
-
Garvin Hicking commented on patch set 3 CR +1 V +1 10/01/24, 17:54
Unsure about the commit title, but I have nothing better 😅 Thanks for taking care! -
Chris Müller voted on patch set 3 CR +1 V +1 10/01/24, 18:00
-
Garvin Hicking voted on patch set 3 CR +2 V +2 10/01/24, 19:20
-
Thomas Hohn commented on patch set 3 10/02/24, 04:59
Reply
Revise Breaking-100229-ConvertJSConfirmationToBitSet.rst ? -
Garvin Hicking commented on patch set 3 10/02/24, 06:07
Reply
That was the first variant I wasn't too happy with either. i think with the "docs" tag it should be good, not resetting votes for it, hope thats fine with all! -
Garvin Hicking merged patch set 4 10/02/24, 06:07
Breaking-100229-ConvertJSConfirmationToBitSet.rst:42