Review main Merged

86395[TASK] Adjust rst validation

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 10/01/24, 19:56

Commit message

The rst validation is adjusted to allow
one to two whitespaces between the ".."
and the "import" / "index" keywords to
support existing files as well as newly
generated (rst helper tool) ones.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/01/24, 16:43

  2. core-ci voted on patch set 1 V +1 10/01/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66910

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 10/01/24, 16:54

  4. Garvin Hicking commented on patch set 1 10/01/24, 16:55

    I think making this more "lax" is a good beginning to unify the indentation. (see also https://review.typo3.org/c/Packages/TYPO3.CMS/+/86180 for a possible future)
  5. Benjamin Franzke voted on patch set 1 CR +1 V +1 10/01/24, 19:44

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 10/01/24, 19:56

  7. Oli Bartsch merged patch set 2 10/01/24, 19:56