Review main Merged

86398[BUGFIX] Immediately apply backendTitleFormat changes in user setup

Benjamin Franzke CR +2 V +2 Normal +86 −8 updated 10/11/24, 13:49

Commit message

The user setup module now emits an event that is immediately
applied to the module router by the user settings manager,
without requring a full backend reload.

The module router is adapted to react on this attribute
change without reloading the entire module route (therefore
`sitenameFirst` is no longer a reactive property that'd cause a
re-rendeering), but applies the browser title update reactively.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1218

  1. Benjamin Franzke uploaded patch set 1 10/01/24, 20:15

  2. core-ci voted on patch set 1 V +1 10/01/24, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66923

  3. Benjamin Franzke uploaded patch set 2 V +1 10/01/24, 20:55

  4. core-ci voted on patch set 2 V +1 10/01/24, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66925

  5. Benjamin Franzke uploaded patch set 3 V +1 10/01/24, 21:29

  6. core-ci voted on patch set 3 V -1 10/01/24, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66927

  7. Benjamin Franzke uploaded patch set 4 V -1 10/01/24, 21:54

  8. core-ci voted on patch set 4 V +1 10/01/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66930

  9. Benjamin Franzke uploaded patch set 5 V +1 10/08/24, 14:50

  10. core-ci voted on patch set 5 V +1 10/08/24, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67383

  11. Andreas Kienast voted on patch set 5 CR +1 V +1 10/09/24, 05:40

  12. Christian Kuhn voted on patch set 5 CR +1 10/10/24, 14:04

  13. Andreas Kienast uploaded patch set 6 CR +1 V +1 10/11/24, 09:05

  14. Andreas Kienast voted on patch set 6 CR +1 V +1 10/11/24, 09:06

  15. core-ci voted on patch set 6 V +1 10/11/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67575

  16. Frank Nägler voted on patch set 6 CR +1 V +1 10/11/24, 11:22

  17. Benjamin Franzke voted on patch set 6 CR +2 V +2 10/11/24, 13:48

  18. Benjamin Franzke merged patch set 7 10/11/24, 13:49