Review main Merged

86402[TASK] Add centralized SearchableSchemaFieldsCollector

Oli Bartsch CR +2 V +2 Hard +236 −64 updated 10/04/24, 14:21

Commit message

This adds the SearchableSchemaFieldsCollector, as
a centralized service for fetching search fields
for a given table from the Tca Schema.

By centralizing this functionality, it will
be possible to replace the corresponding "ctrl"
option in the future with a new field related
option, such as `searchable`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Guido Schmechel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1724

  1. Oli Bartsch uploaded patch set 1 10/02/24, 07:57

  2. core-ci voted on patch set 1 V -1 10/02/24, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66951

  3. Oli Bartsch uploaded patch set 2 V -1 10/02/24, 08:12

  4. core-ci voted on patch set 2 V -1 10/02/24, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66953

  5. Oli Bartsch uploaded patch set 3 V -1 10/02/24, 09:05

  6. core-ci voted on patch set 3 V -1 10/02/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66958

  7. Benni Mack uploaded patch set 4 V -1 10/02/24, 09:23

  8. core-ci voted on patch set 4 V -1 10/02/24, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66960

  9. Oli Bartsch uploaded patch set 5 V -1 10/02/24, 10:11

  10. core-ci voted on patch set 5 V +1 10/02/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66968

  11. Benni Mack voted on patch set 5 CR +1 V +1 10/02/24, 10:33

  12. Guido Schmechel commented on patch set 5 10/02/24, 10:58

    SearchableSchemaFieldsCollector.php:1

    Even if it is only code takeover. What about unit tests for this new class?
  13. Oli Bartsch uploaded patch set 6 CR +1 V +1 10/02/24, 14:00

  14. Oli Bartsch commented on patch set 6 10/02/24, 14:00

    SearchableSchemaFieldsCollector.php:1 Reply

    Done
  15. Oli Bartsch uploaded patch set 7 10/02/24, 14:01

  16. core-ci voted on patch set 6 V +1 10/02/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66978

  17. core-ci voted on patch set 7 V +1 10/02/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66980

  18. Benni Mack voted on patch set 7 CR +1 V +1 10/02/24, 14:29

  19. Guido Schmechel voted on patch set 7 CR +1 10/02/24, 18:02

  20. Kevin Appelt commented on patch set 7 10/04/24, 13:05

    Not sure if related in any way, but just on mobile right now and wanted to make sure it does not go unseen: please check if this needs to consider https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/Search.html#confval-andwhere
  21. Markus Klein commented on patch set 7 CR +1 10/04/24, 13:15

    Reply

    this feature isn't touched here. So should be good.
  22. Markus Klein voted on patch set 7 V +1 10/04/24, 13:21

  23. Oli Bartsch voted on patch set 7 CR +2 V +2 10/04/24, 14:21

  24. Oli Bartsch merged patch set 8 10/04/24, 14:21