86402[TASK] Add centralized SearchableSchemaFieldsCollector
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Guido Schmechel +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+3 −3
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+19 −27
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+3 −11
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+3 −11
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+3 −6
- typo3/sysext/core/Classes/Schema/SearchableSchemaFieldsCollector.php2new+63 −0
- typo3/sysext/core/Tests/Functional/Schema/SearchableSchemaFieldsCollectorTest.phpnew+135 −0
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+4 −5
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+3 −1
Review log 1724
-
Oli Bartsch uploaded patch set 1 10/02/24, 07:57
-
core-ci voted on patch set 1 V -1 10/02/24, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66951
-
Oli Bartsch uploaded patch set 2
V -110/02/24, 08:12 -
core-ci voted on patch set 2 V -1 10/02/24, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66953
-
Oli Bartsch uploaded patch set 3
V -110/02/24, 09:05 -
core-ci voted on patch set 3 V -1 10/02/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66958
-
Benni Mack uploaded patch set 4
V -110/02/24, 09:23 -
core-ci voted on patch set 4 V -1 10/02/24, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66960
-
Oli Bartsch uploaded patch set 5
V -110/02/24, 10:11 -
core-ci voted on patch set 5 V +1 10/02/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66968
-
Benni Mack voted on patch set 5 CR +1 V +1 10/02/24, 10:33
-
Guido Schmechel commented on patch set 5 10/02/24, 10:58
-
Oli Bartsch uploaded patch set 6
CR +1V +110/02/24, 14:00 -
Oli Bartsch commented on patch set 6 10/02/24, 14:00
SearchableSchemaFieldsCollector.php:1ReplyDone -
Oli Bartsch uploaded patch set 7 10/02/24, 14:01
-
core-ci voted on patch set 6 V +1 10/02/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66978
-
core-ci voted on patch set 7 V +1 10/02/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66980
-
Benni Mack voted on patch set 7 CR +1 V +1 10/02/24, 14:29
-
Guido Schmechel voted on patch set 7 CR +1 10/02/24, 18:02
-
Kevin Appelt commented on patch set 7 10/04/24, 13:05
Not sure if related in any way, but just on mobile right now and wanted to make sure it does not go unseen: please check if this needs to consider https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/Search.html#confval-andwhere -
Markus Klein commented on patch set 7 CR +1 10/04/24, 13:15
Reply
this feature isn't touched here. So should be good. -
Markus Klein voted on patch set 7 V +1 10/04/24, 13:21
-
Oli Bartsch voted on patch set 7 CR +2 V +2 10/04/24, 14:21
-
Oli Bartsch merged patch set 8 10/04/24, 14:21
SearchableSchemaFieldsCollector.php:1