Review main Abandoned

86403[TASK] Allow mocking of `ModuleTemplateFactory`

Oliver Klee CR 0 V 0 Easy +44 −1 updated 10/02/24, 08:55

Commit message

To be able to unit-test BE controllers, it should be possible to
mock/stub `ModuleTemplateFactory`, and due to the way PHPUnit mocks
and stubs work, this is only possible is this class is not final.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Oliver Klee uploaded patch set 1 10/02/24, 08:08

  2. core-ci voted on patch set 1 V +1 10/02/24, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66952

  3. Andreas Kienast commented on patch set 1 CR -1 10/02/24, 08:16

    Controller should always be covered with functional tests, not unit tests.
  4. Benjamin Franzke commented on patch set 1 CR -2 10/02/24, 08:19

    Unresolved

    Testing must not influence code design. Fix your testing.
  5. Oliver Klee abandoned the change 10/02/24, 08:55