Review main Merged

86404[BUGFIX] Make forms module context and small screen aware

Benjamin Kott CR +2 V +2 Nightmare +1525 −1811 updated 10/10/24, 14:48

Commit message

The forms module has been made context-aware,
improving its usability on small screen devices.
The interface has been polished and the button
positioning has been streamlined for better
accessibility in all conditions.

The inspector and structure browser now collapses
when there isn't enough space and can be toggled
into view when needed.

Element identifiers are now visible in the
inspector, making it easier for integrators and
users to reference elements.

The structure browser has been visually aligned
with existing trees in the backend, though it
doesn't yet use the tree component due to the
need for further refactoring of the data handling
within the forms module.

Steps can now be created directly within the main
editor, allowing the structure browser to take
more space while keeping the button consistently
available during form editing.

The Settings button has been attached directly to
the form title to prevent layout shifts and ensure
accessibility in all view modes. Finally, step
names now have a fallback mechanism, allowing
them to be selected even when no name is set
through the editor.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 50

Show 30 more files

Review log 2536

Show 11 earlier messages
  1. Benjamin Kott uploaded patch set 1 10/02/24, 08:57

  2. Benjamin Kott uploaded patch set 2 10/02/24, 14:01

  3. Benjamin Kott uploaded patch set 3 10/04/24, 08:34

  4. Benjamin Kott uploaded patch set 4 10/04/24, 09:06

  5. Benjamin Kott uploaded patch set 5 10/04/24, 12:46

  6. Benjamin Kott uploaded patch set 6 10/04/24, 12:49

  7. Benjamin Kott uploaded patch set 7 10/04/24, 13:26

  8. Benjamin Kott uploaded patch set 8 10/07/24, 08:09

  9. Benjamin Kott uploaded patch set 9 10/07/24, 09:22

  10. Benjamin Kott uploaded patch set 10 10/07/24, 09:56

  11. Benjamin Kott wrote 10/07/24, 09:57

    Unset private
  1. Benjamin Kott uploaded patch set 11 10/07/24, 10:13

  2. core-ci voted on patch set 10 V -1 10/07/24, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67221

  3. Benjamin Kott uploaded patch set 12 10/07/24, 10:18

  4. core-ci voted on patch set 12 V +1 10/07/24, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67225

  5. core-ci voted on patch set 11 V +1 10/07/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67222

  6. Andreas Kienast uploaded patch set 13 V +1 10/10/24, 09:21

  7. core-ci voted on patch set 13 V +1 10/10/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67487

  8. Benjamin Franzke uploaded patch set 14 V +1 10/10/24, 09:31

  9. core-ci voted on patch set 14 V +1 10/10/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67491

  10. Benjamin Kott uploaded patch set 15 V +1 10/10/24, 11:08

  11. core-ci voted on patch set 15 V +1 10/10/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67500

  12. Benjamin Franzke uploaded patch set 16 V +1 10/10/24, 11:29

  13. core-ci voted on patch set 16 V +1 10/10/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67503

  14. Benjamin Kott uploaded patch set 17 V +1 10/10/24, 12:26

  15. core-ci voted on patch set 17 V +1 10/10/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67508

  16. Benjamin Franzke uploaded patch set 18 V +1 10/10/24, 12:50

  17. core-ci voted on patch set 18 V +1 10/10/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67509

  18. Andreas Kienast commented on patch set 18 V -1 10/10/24, 13:16

    "Validators" labels are broken
  19. Andreas Kienast uploaded patch set 19 V +1 10/10/24, 14:08

  20. core-ci voted on patch set 19 V +1 10/10/24, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67512

  21. Benjamin Kott uploaded patch set 20 V +1 10/10/24, 14:41

  22. core-ci voted on patch set 20 V +1 10/10/24, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67515

  23. Andreas Kienast voted on patch set 20 CR +1 V +1 10/10/24, 14:47

  24. Benjamin Franzke voted on patch set 20 CR +2 V +2 10/10/24, 14:48

  25. Benjamin Franzke merged patch set 21 10/10/24, 14:48