Review main Merged

86405[TASK] Use TCA schema for fetching relevant fields

Oli Bartsch CR +2 V +2 Hard +308 −73 updated 10/08/24, 07:43

Commit message

Both ElementInformationController as well as RemoteServer previously
booted up FormEngine to fetch relevant fields for being displayed in
corresponding views.

This is bad in multiple terms: performance, misuse of FormEngine,
dependency to PSR-7, etc.

Therefore, a new VisibleSchemaFieldsCollector is introduced, which
uses the TCA schema to provide the fields to be displayed, depending
on the record type, the language context and the current backend user.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1830

Show 35 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/02/24, 10:05

  2. core-ci voted on patch set 1 V +1 10/02/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66967

  3. Oli Bartsch uploaded patch set 2 V +1 10/02/24, 12:27

  4. core-ci voted on patch set 2 V -1 10/02/24, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66975

  5. Oli Bartsch uploaded patch set 3 V -1 10/02/24, 13:06

  1. core-ci voted on patch set 3 V +1 10/02/24, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66976

  2. Oli Bartsch uploaded patch set 4 V +1 10/02/24, 13:11

  3. core-ci voted on patch set 4 V +1 10/02/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66977

  4. Oli Bartsch uploaded patch set 5 V +1 10/04/24, 10:39

  5. core-ci voted on patch set 5 V -1 10/04/24, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67068

  6. core-ci voted on patch set 5 V +1 10/04/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67068

  7. Simon Schaufelberger updated the commit message in patch set 6 V +1 10/04/24, 13:23

  8. Simon Schaufelberger commented on patch set 6 10/04/24, 13:27

    VisibleSchemaFieldsCollector.php:86

    return type for closure missing

    RemoteServer.php:69

    is this trailing comma intended?
  9. core-ci voted on patch set 6 V +1 10/04/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67094

  10. Andreas Kienast commented on patch set 6 10/04/24, 13:44

    RemoteServer.php:69 Reply

    This is totally fine since PHP 8.0.
  11. Oli Bartsch uploaded patch set 7 V +1 10/04/24, 14:00

  12. Oli Bartsch commented on patch set 7 10/04/24, 14:01

    VisibleSchemaFieldsCollector.php:86 Reply

    Done
  13. core-ci voted on patch set 7 V +1 10/04/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67098

  14. Oli Bartsch uploaded patch set 8 V +1 10/04/24, 14:28

  15. core-ci voted on patch set 8 V +1 10/04/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67101

  16. Oli Bartsch uploaded patch set 9 V +1 10/05/24, 08:23

  17. Oli Bartsch uploaded patch set 10 10/05/24, 08:24

  18. core-ci voted on patch set 10 V +1 10/05/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67140

  19. core-ci voted on patch set 9 V +1 10/05/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67139

  20. Oli Bartsch uploaded patch set 11 V +1 10/07/24, 15:35

  21. core-ci voted on patch set 11 V +1 10/07/24, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67257

  22. Christian Kuhn voted on patch set 11 CR +1 V +1 10/07/24, 16:20

  23. Benni Mack voted on patch set 11 CR +1 V +1 10/08/24, 06:49

  24. Oli Bartsch voted on patch set 11 CR +2 V +2 10/08/24, 07:43

  25. Oli Bartsch merged patch set 12 10/08/24, 07:43