86407[TASK] Allow sets to be excluded from site configuration GUI
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Configuration/TCA/ItemsProcessorFunctions.php+0 −12
- typo3/sysext/core/Classes/Command/SiteSetsListCommand.php+19 −4
- typo3/sysext/core/Classes/Site/Set/SetDefinition.php+1 −0
- typo3/sysext/core/Classes/Site/TcaSiteSetCollector.php2+15 −1
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103437-IntroduceSiteSets.rst2+34 −0
Review log 1926
Show 1 earlier messages
-
Benjamin Franzke uploaded patch set 1 10/03/24, 13:27
-
core-ci voted on patch set 1 V +1 10/03/24, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67009
-
Garvin Hicking commented on patch set 1 10/03/24, 14:20
Some ideas that might fit for an easier understanding: - internal - restricted - sealed - protected - locked and a few more off-the-track: - concealed - contained - vaulted IMO "internal" is an established one...? -
Garvin Hicking commented on patch set 1 10/03/24, 14:48
Reply
(or maybe simply descriptive: excludedFromGui) -
Benjamin Franzke uploaded patch set 2
V +110/03/24, 21:49 -
Benjamin Franzke commented on patch set 2 10/03/24, 21:49
Reply
thx, I think I'll go with `hidden` for simplicity and introduce an additional user tsconfig setting `options.hideSets` (to match `options.hideModules`) – or maybe `options.hideSiteSets` or `options.sites.hideSets`. -
core-ci voted on patch set 2 V +1 10/03/24, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67034
-
Benjamin Franzke uploaded patch set 3
V +110/04/24, 05:35 -
core-ci voted on patch set 3 V +1 10/04/24, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67051
-
Garvin Hicking commented on patch set 4
V +110/04/24, 05:54Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 10/04/24, 06:08
(I rephrased a small sentences in the changelog, please check if I didn't mangle your intent)TcaSiteSetCollector.php:46How about extracting a method for getSelectedSets? That would also allow to add a function test for it...? -
core-ci voted on patch set 4 V +1 10/04/24, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67052
-
Garvin Hicking commented on patch set 4 CR +1 10/04/24, 06:12
TcaSiteSetCollector.php:46ReplyThinking on it, nvm, can be done in .1 later, not wanting to add workload here. -
Benjamin Franzke uploaded patch set 5
CR +1V +110/04/24, 06:42 -
Benjamin Franzke uploaded patch set 6 10/04/24, 06:45
-
Benjamin Franzke commented on patch set 6 10/04/24, 06:45
Reply
thx (overpushed by accident, but restored now) -
Mathias Brodala commented on patch set 6 10/04/24, 06:48
Feature-103437-IntroduceSiteSets.rst:134This sounds like TYPO3 logic: add something to remove it somewhere. ;-) If feasible, an "options.sites.availableSets" option would be better which is populated from the sets. Then "removeFromList()" can be used to make this feature self-explanatory. -
Benjamin Franzke rebased onto patch set 7 10/04/24, 06:55
-
core-ci voted on patch set 6 V +1 10/04/24, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67055
-
core-ci voted on patch set 7 V +1 10/04/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67057
-
Benjamin Franzke commented on patch set 7 10/04/24, 10:09
Feature-103437-IntroduceSiteSets.rst:134ReplyI did this to conform to existing settings like `hideModules` and I don't like the implication of an option named `options.sites.availableSets` – that sounds (in terms of "self-explanatory") like a set always has to be registered manually in here. Sorry, I don't want this. (I'd be fine with an additional allow-list instead of a deny list, `hideSets` should actually be fine IMO). -
Benjamin Franzke rebased onto patch set 8
V +110/04/24, 12:57 -
core-ci voted on patch set 8 V +1 10/04/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67091
-
Benjamin Kott voted on patch set 8 CR +1 V +1 10/14/24, 13:34
-
Andreas Kienast voted on patch set 8 CR +2 V +2 10/14/24, 13:50
-
Andreas Kienast merged patch set 9 10/14/24, 13:51