Review main Merged

86412[TASK] Update typo3/class-alias-loader for PHP 8.4 compatibility

Benjamin Franzke CR +2 V +2 Easy +11 −11 updated 10/31/24, 08:09

Commit message

Executed commands:

  composer req "typo3/class-alias-loader:^1.2" \
    --no-update -d typo3/sysext/core
  composer req "typo3/class-alias-loader:^1.2"

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1725

  1. Benjamin Franzke uploaded patch set 1 10/03/24, 16:22

  2. core-ci voted on patch set 1 V -1 10/03/24, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67019

  3. core-ci commented on patch set 1 10/03/24, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67019

  4. Benjamin Franzke uploaded patch set 2 V -1 10/03/24, 16:44

  5. Benjamin Franzke uploaded patch set 3 10/03/24, 16:47

  6. core-ci voted on patch set 2 V -1 10/03/24, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67020

  7. Benjamin Franzke uploaded patch set 4 10/03/24, 16:53

  8. core-ci voted on patch set 3 V -1 10/03/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67021

  9. core-ci voted on patch set 3 V -1 10/03/24, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67021

  10. core-ci voted on patch set 4 V -1 10/03/24, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67022

  11. Benjamin Franzke marked it work in progress 10/07/24, 09:44

  12. Benjamin Franzke uploaded patch set 5 V -1 10/09/24, 12:14

  13. core-ci voted on patch set 5 V -1 10/09/24, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67444

  14. Oliver Hader updated the commit message in patch set 6 V -1 10/18/24, 13:59

  15. Benjamin Franzke uploaded patch set 7 10/29/24, 08:49

  16. Benjamin Franzke marked it ready for review 10/29/24, 08:49

  17. core-ci voted on patch set 7 V +1 10/29/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68766

  18. Benni Mack voted on patch set 7 CR +1 V +1 10/29/24, 12:44

  19. Benni Mack commented on patch set 7 10/29/24, 12:45

    usually, I'm not a huge fan of requiring the new version (instead just doing "composer update typo3/class-alias-loader") but since this is also a package that is maintained by us (= following sem-ver) I'm fine with this.
  20. Benjamin Franzke commented on patch set 7 10/29/24, 12:56

    Reply

    We can leave that out for the backports and only update composer.lock if you like that better. Since we do not directly rely on any new features, that's fine…
  21. Benni Mack commented on patch set 7 10/29/24, 13:08

    Reply

    for v12 this might be the best idea.
  22. Benjamin Franzke commented on patch set 7 10/29/24, 17:40

  23. Garvin Hicking voted on patch set 7 CR +1 V +1 10/30/24, 13:49

  24. Benjamin Franzke voted on patch set 7 CR +2 V +2 10/31/24, 08:09

  25. Benjamin Franzke merged patch set 8 10/31/24, 08:09