Review main Merged

86413[BUGFIX] Load set provided TypoScript in extbase configuration manager

Benjamin Franzke CR +2 V +2 Easy +9 −4 updated 10/04/24, 11:33

Commit message

In order to load extension statics and global TypoScript, the extbase
configuration manager provides a fake sys_template row if no real
sys_template row has been found.

Since sites with sets do not require sys_template rows to be existent,
this heuristic overlayed a fake sys_template record on top of the
site set provided TypoScript. The site set TypoScript was actually still
loaded, but cleared by the clear flag of the fake sys_template record,
which means that all set-provided TypoScript was silently discarded
and only global TypoScript was loaded.

The extbase backend configuration manager is now made aware of site sets
to avoid adding a fake sys_template row if it is used in a site context
where sets are configured.

With #103580 and #103556 the default TypoScript of EXT:form has been
excluded from site-set provided TypoScript with the intention to only
load it if the typo3/form set is actually loaded. This was not correct:
 a) module.tx_form is not contained in the typo3/form set at all,
    and therefore still needs to be provided – or moved into the set,
    but that's current not possible because of b)
 b) module.tx_form TypoScript is (currently) needed globally, as the
    EXT:form backend module is not scoped to sites. That means we can
    not rely on the possibility that typo3/form set has been included
    in a site. (remember EXT:form will use the TypoScript from the
    "first" found root page, that means there is no guarantee that
    the set is loaded)

Therefore EXT:form backend TypoScript is now marked as default
TypoScript, not just for sys_template, but also for site sets.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1520

  1. Benjamin Franzke uploaded patch set 1 10/03/24, 19:53

  2. Benjamin Franzke uploaded patch set 2 10/03/24, 19:54

  3. Benjamin Franzke commented on patch set 2 CR -1 10/03/24, 20:13

    Does not yet fix https://forge.typo3.org/issues/104150 – but that should be adressed within the same change, as this will cause the set-provided typoscript to be used and therefore breaks the Form Backend if the set-provided typoscript is used on the first root page.
  4. core-ci voted on patch set 2 V -1 10/03/24, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67031

  5. Benjamin Franzke uploaded patch set 3 CR -1 V -1 10/03/24, 20:38

  6. Benjamin Franzke commented on patch set 3 10/03/24, 20:38

    Reply

    Done.
  7. Benjamin Franzke uploaded patch set 4 10/03/24, 20:41

  8. core-ci voted on patch set 3 V -1 10/03/24, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67032

  9. core-ci voted on patch set 4 V +1 10/03/24, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67033

  10. Stefan Bürk voted on patch set 4 CR +1 10/03/24, 22:51

  11. Benjamin Franzke updated the commit message in patch set 5 CR +1 V +1 10/04/24, 07:07

  12. core-ci voted on patch set 5 V +1 10/04/24, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67058

  13. Torben Hansen updated the commit message in patch set 6 V +1 10/04/24, 08:13

  14. Torben Hansen voted on patch set 6 CR +1 V +1 10/04/24, 08:14

  15. core-ci voted on patch set 6 V +1 10/04/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67060

  16. Simon Schaufelberger voted on patch set 6 CR +1 10/04/24, 08:31

  17. Stefan Bürk voted on patch set 6 CR +1 V +1 10/04/24, 10:49

  18. Oliver Hader voted on patch set 6 CR +1 10/04/24, 11:21

  19. Benjamin Franzke voted on patch set 6 CR +2 V +2 10/04/24, 11:33

  20. Benjamin Franzke merged patch set 7 10/04/24, 11:33