Review main Merged

86414[BUGFIX] Repair core-updater result and avoid JS error

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 10/11/24, 07:52

Commit message

With #101576 the install tool Progressbar was migrated to lit,
and jquery code (which silently ignores non available elements)
tried to remove new progressbar component that was actually never
rendered in the core-updater – it only shows a loading message.

With the migration from jQuery to querySelector in #101655, this became
an issue, since the element is not found and `remove()` was called on
null, leading to an JS error and aborting the action. That means the
core updater result was never shown.

The loading flash message is now gracefully removed, so that the
result is shown in any case.

The loading message should be migrated to the new progress bar
component, but that's up for another change.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 67

  1. Benjamin Franzke uploaded patch set 1 10/03/24, 22:32

  2. core-ci voted on patch set 1 V +1 10/03/24, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67035

  3. Andreas Kienast voted on patch set 1 CR +1 10/04/24, 06:24

  4. Benjamin Kott voted on patch set 1 CR +1 V +1 10/11/24, 07:05

  5. Georg Ringer voted on patch set 1 CR +1 V +1 10/11/24, 07:32

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 10/11/24, 07:52

  7. Andreas Kienast merged patch set 2 10/11/24, 07:52