Review main Merged

86421[BUGFIX] Show site name in Install Tool header

Markus Klein CR +2 V +2 Easy +4 −5 updated 10/05/24, 08:06

Commit message

The "site name" is missing in the Install Tool
header, add the missing view variable.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1518

  1. Markus Klein uploaded patch set 1 10/04/24, 13:37

  2. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/04/24, 13:51

  3. core-ci voted on patch set 1 V +1 10/04/24, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67097

  4. Oli Bartsch commented on patch set 1 10/04/24, 14:20

    AbstractController.php:56

    I suggest adding a null coalescing to prevent possible PHP errors. Additionally I suggest to change corresponding template to check for the siteName being set to prevent the string `on site: ` So: `<span class="topbar-site-name">Install Tool<f:if condition="{siteName}"> on site: {siteName}</f:if></span>` Note the change of Admin tool => "Install Tool", to be consistent in the naming.
  5. Markus Klein uploaded patch set 2 CR +1 V +1 10/04/24, 14:28

  6. Markus Klein commented on patch set 1 10/04/24, 14:29

    AbstractController.php:56 Reply

    Done
  7. Oli Bartsch commented on patch set 2 CR +1 V +1 10/04/24, 14:37

    ShowLogin.html:5

    This display looks really odd. However, this should be handled separately.
  8. core-ci voted on patch set 2 V +1 10/04/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67102

  9. Markus Klein commented on patch set 2 10/04/24, 14:58

    ShowLogin.html:5 Reply

    Yep... I thought so too.
  10. Georg Ringer voted on patch set 2 CR +1 V +1 10/04/24, 15:27

  11. Thomas Hohn voted on patch set 2 CR +1 10/04/24, 15:33

  12. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 10/04/24, 15:36

  13. Oli Bartsch voted on patch set 3 CR +1 V +1 10/04/24, 15:37

  14. core-ci voted on patch set 3 V +1 10/04/24, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67105

  15. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/04/24, 16:10

  16. Torben Hansen voted on patch set 3 CR +1 V +1 10/04/24, 16:35

  17. Oli Bartsch voted on patch set 3 CR +2 V +2 10/05/24, 08:05

  18. Oli Bartsch merged patch set 4 10/05/24, 08:06