Review main Abandoned

86423[BUGFIX] Ensure FAL can deal with absolute paths from extensions

Benni Mack CR 0 V 0 Easy +3 −1 updated 10/07/24, 09:51

Commit message

If you're using something like this in
Fluid:
<img src="{f:uri.resource(path: 'EXT:mysite/Resources/Public/Images/language.svg')}"

or this in TypoScript:

lib.headerlogo = IMAGE
lib.headerlogo {
  file = EXT:mysite/Resources/Public/Images/logo.png
  file.height = {$page.headerLogoHeight}
  params = class="header-logo"
  stdWrap {
    typolink.parameter = {$page.mainLink}
  }
}

Then, you might have problems with wild setups
in
a) double symlinked setups
b) setups where TYPO3 is not in document root

using composer-installers-v5 (yes, also in v11 with v4-rc1).
This is because, the path
"/_assets/.../language.svg" is resolved as "absolute web path"
and thus, making a huge problem if the path cannot br resolved
anymore as TYPO3 thinks this is "absolute" now and can't find it.

I keep this here as a reference for everyone who wants
to composer-patch their installation

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 10/04/24, 19:40

  2. core-ci voted on patch set 1 V +1 10/04/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67112

  3. Garvin Hicking commented on patch set 1 10/04/24, 21:36

    (Think this could be a part of https://forge.typo3.org/issues/101911 and its related tickets)
  4. Mathias Brodala commented on patch set 1 10/07/24, 08:40

    Unresolved

    This was now fixed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/83043 so this one here should be abandoned.
  5. Benni Mack abandoned the change 10/07/24, 09:51

    merged now