86434[BUGFIX] Fix virtual embedded install tool url in subdir installation
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/module/router.ts4+2 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+3 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html3+9 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module/router.js+2 −2
- typo3/sysext/backend/Tests/Functional/Controller/BackendControllerTest.php+7 −0
Review log 1114
-
Benjamin Franzke uploaded patch set 1 10/05/24, 18:54
-
core-ci voted on patch set 1 V -1 10/05/24, 19:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67158
-
Benjamin Franzke uploaded patch set 2
V -110/07/24, 06:21 -
core-ci voted on patch set 2 V -1 10/07/24, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67203
-
core-ci voted on patch set 2 V +1 10/07/24, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67203
-
Andreas Kienast commented on patch set 2 10/11/24, 07:47
Main.html:51excess whitespace -
Andreas Kienast commented on patch set 2 10/11/24, 07:47
router.ts:219ReplyOr does this conflict with the configurable entry point? -
Benjamin Franzke commented on patch set 2 10/11/24, 08:01
router.ts:219ReplyInstalltool is always mounted on `/typo3/install.php` and does not respect the configured (virtual) entry point. (Otherwise installtool would need to be routed and would be broken with broken htaccess rules or so) -
Andreas Kienast commented on patch set 2 10/11/24, 08:03
router.ts:219ReplyAcknowledged -
Benjamin Franzke commented on patch set 2 10/11/24, 08:04
Main.html:51ReplyNo, has 4 space indent and that may only look wrong due to `s` vs `{` rendering. The lines are properly aligned. -
Benjamin Kott voted on patch set 2 CR +1 V +1 10/11/24, 08:06
-
Andreas Kienast voted on patch set 2 CR +2 V +2 10/11/24, 08:50
-
Andreas Kienast merged patch set 3 10/11/24, 08:50
-
Benjamin Franzke commented on patch set 3 10/11/24, 10:05
Main.html:51ReplyDone
router.ts:219