Review main Merged

86434[BUGFIX] Fix virtual embedded install tool url in subdir installation

Benjamin Franzke CR +2 V +2 Easy +23 −4 updated 10/11/24, 10:05

Commit message

The embedded install tool is dispatched from a virtual module URL –
{entryPoint}/module/tools/… – to {instancePath}typo3/index.php.

The backend module router takes care to virtually replace
{instancePath}typo3/index.php by {entryPoint}/module/tools/
in order for browser-reload to work.

When this virtual is created, the instance path needs to be
taken into accounts instead of implying TYPO3 path is `/`,
which is not the case in a sub directory installation.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1114

  1. Benjamin Franzke uploaded patch set 1 10/05/24, 18:54

  2. core-ci voted on patch set 1 V -1 10/05/24, 19:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67158

  3. Benjamin Franzke uploaded patch set 2 V -1 10/07/24, 06:21

  4. core-ci voted on patch set 2 V -1 10/07/24, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67203

  5. core-ci voted on patch set 2 V +1 10/07/24, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67203

  6. Andreas Kienast commented on patch set 2 10/11/24, 07:47

    router.ts:219

    Wouldn't `this.entryPoint + '/install.php'` archive the same result?

    Main.html:51

    excess whitespace
  7. Andreas Kienast commented on patch set 2 10/11/24, 07:47

    router.ts:219 Reply

    Or does this conflict with the configurable entry point?
  8. Benjamin Franzke commented on patch set 2 10/11/24, 08:01

    router.ts:219 Reply

    Installtool is always mounted on `/typo3/install.php` and does not respect the configured (virtual) entry point. (Otherwise installtool would need to be routed and would be broken with broken htaccess rules or so)
  9. Andreas Kienast commented on patch set 2 10/11/24, 08:03

    router.ts:219 Reply

    Acknowledged
  10. Benjamin Franzke commented on patch set 2 10/11/24, 08:04

    Main.html:51 Reply

    No, has 4 space indent and that may only look wrong due to `s` vs `{` rendering. The lines are properly aligned.
  11. Benjamin Kott voted on patch set 2 CR +1 V +1 10/11/24, 08:06

  12. Andreas Kienast voted on patch set 2 CR +2 V +2 10/11/24, 08:50

  13. Andreas Kienast merged patch set 3 10/11/24, 08:50

  14. Benjamin Franzke commented on patch set 3 10/11/24, 10:05

    Main.html:51 Reply

    Done