86436[BUGFIX] Ensure correct type resolving in `AbstractSchemaManager`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 4
- Task #105208Ensure correct type resolving in `AbstractSchemaManager`
- Bug #105004PHP Warning: Array to string conversion when persisting JSON data (persists "Array" if warnings are silenced)
- Bug #105005Webhooks Exception if invalid JSON in database field additional_headers
- Feature #99062Native JSON field support in Doctrine DBAL
Files 19
- typo3/sysext/core/Classes/Database/Platform/Traits/GetColumnDeclarationSQLCommentTypeAwareTrait.php4new+127 −0
- typo3/sysext/core/Classes/Database/Platform/Traits/MySQLCompatibleAlterTablePlatformAwareTrait.phprenamed+1 −1
- typo3/sysext/core/Classes/Database/Platform/MariaDB1010Platform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1052Platform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1060Platform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDBPlatform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/MySQL80Platform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/MySQL84Platform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/MySQLPlatform.php+3 −0
- typo3/sysext/core/Classes/Database/Platform/PostgreSQLPlatform.php+5 −1
- typo3/sysext/core/Classes/Database/Platform/SQLitePlatform.php+5 −1
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/ColumnTypeCommentMethodsTrait.phpnew+105 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomDoctrineTypesColumnDefinitionTrait.php+3 −2
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/MySQLSchemaManager.php+189 −1
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/PostgreSQLSchemaManager.php+194 −2
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/SQLiteSchemaManager.php+28 −0
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php3+1 −13
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+51 −0
- typo3/sysext/webhooks/Tests/Functional/WebhookExecutionTest.php+88 −0
Review log 2637
Show 812 earlier messages
-
Stefan Bürk uploaded patch set 1 10/05/24, 21:55
-
core-ci voted on patch set 1 V -1 10/05/24, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67164
-
Stefan Bürk updated the commit message in patch set 2
V -110/05/24, 22:27 -
core-ci voted on patch set 2 V -1 10/05/24, 22:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67167
-
Stefan Bürk uploaded patch set 3
V -110/06/24, 12:23 -
Stefan Bürk updated the commit message in patch set 4 10/06/24, 12:33
-
core-ci voted on patch set 3 V +1 10/06/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67181
-
core-ci voted on patch set 4 V +1 10/06/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67182
-
Benjamin Franzke commented on patch set 4 10/07/24, 13:09
BUGFIXSeems to resolve https://forge.typo3.org/issues/104781 as well(?) -
Benjamin Franzke commented on patch set 4 10/07/24, 13:21
Reply
Maybe also https://forge.typo3.org/issues/104316 (?) -
Stefan Bürk updated the commit message in patch set 5
V +110/07/24, 13:42 -
Stefan Bürk commented on patch set 5 10/07/24, 13:42
Reply
DoneReply
Sorry, no. This change does not solve any of the two mentioned issues. That need other work.
-
core-ci voted on patch set 5 V +1 10/07/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67240
-
Stefan Bürk commented on patch set 5 10/10/24, 17:35
Reply
Done -
Stefan Bürk rebased onto patch set 6
V +110/10/24, 17:35 -
core-ci voted on patch set 6 V +1 10/10/24, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67525
-
Stefan Bürk rebased onto patch set 7
V +110/11/24, 09:08 -
Christian Kuhn commented on patch set 7 10/11/24, 09:20
these two links are 404 -
core-ci voted on patch set 7 V +1 10/11/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67576
-
Stefan Bürk uploaded patch set 8
V +110/11/24, 09:29 -
Stefan Bürk commented on patch set 8 10/11/24, 09:30
Reply
Changed. -
core-ci voted on patch set 8 V -1 10/11/24, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67579
-
core-ci voted on patch set 8 V +1 10/11/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67579
-
Benjamin Franzke voted on patch set 8 V +1 10/11/24, 10:11
-
Benjamin Franzke commented on patch set 8 10/11/24, 10:12
GetColumnDeclarationSQLCommentTypeAwareTrait.php:25I guess this code has been extracted from doctrine v2? Can we link to the source, wherever we've taken code from? -
Andreas Kienast commented on patch set 8 10/11/24, 10:52
ConnectionMigrator.php:299What issue is solved by moving the condition into the loop? This looks like a no-op for sqlite/postgres. -
Christian Kuhn voted on patch set 8 CR +1 V +1 10/11/24, 11:06
-
Stefan Bürk commented on patch set 8 10/11/24, 11:35
GetColumnDeclarationSQLCommentTypeAwareTrait.php:25ReplyGood point, will update. I have to use commit hash gitbub urls for that, because doctrine deletes branches all along. Origin was dbal v3.ConnectionMigrator.php:299ReplyGood point. That change is a left over. In the first tries to solve this issue, I hooked here in - and needed it for all platforms, and just doing the maria/mysql stuff - thus moved the condition in to avoid at least here two foreach loops on these two platforms. Will revert that, not needed now. -
Stefan Bürk uploaded patch set 9
CR +1V +110/11/24, 12:30 -
Stefan Bürk uploaded patch set 10 10/11/24, 12:31
-
Stefan Bürk commented on patch set 10 10/11/24, 12:32
GetColumnDeclarationSQLCommentTypeAwareTrait.php:25ReplyAdde links to sources and some words on several places. Hope that I catched everything and that this is what you meant.ConnectionMigrator.php:299ReplyDone -
core-ci voted on patch set 9 V +1 10/11/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67595
-
core-ci voted on patch set 10 V +1 10/11/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67596
-
Benjamin Franzke commented on patch set 10 CR +1 V +1 10/11/24, 13:48
GetColumnDeclarationSQLCommentTypeAwareTrait.php:25Replyyup, thanks a lot! -
Christian Kuhn voted on patch set 10 CR +1 V +1 10/11/24, 15:08
-
Stefan Bürk voted on patch set 10 CR +2 V +2 10/11/24, 15:18
-
Stefan Bürk merged patch set 11 10/11/24, 15:18