Review main Merged

86441[BUGFIX] POST request with empty object generates a Bad multipart error

Filipe DA COSTA CR +2 V +2 Easy +6 −2 updated 03/27/25, 14:16

Commit message

Return an empty string as body if we have an empty javascript object,
instead of running InputTransformer.byHeader() on it and create an
empty FormData that produces those boundaries.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Filipe DA COSTA uploaded patch set 1 10/07/24, 09:55

  2. Andreas Kienast commented on patch set 1 10/07/24, 09:56

    Can you please provide tests for your scenario?
  3. core-ci voted on patch set 1 V +1 10/07/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67220

  4. Filipe DA COSTA uploaded patch set 2 V +1 10/07/24, 11:19

  5. core-ci voted on patch set 2 V +1 10/07/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67229

  6. Filipe DA COSTA commented on patch set 2 10/07/24, 13:14

    Reply

    Done
  7. Filipe DA COSTA rebased onto patch set 3 V +1 03/20/25, 21:04

  8. core-ci voted on patch set 3 V +1 03/20/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75910

  9. Andreas Kienast uploaded patch set 4 V +1 03/27/25, 14:01

  10. Andreas Kienast updated the commit message in patch set 5 03/27/25, 14:01

  11. Andreas Kienast voted on patch set 5 CR +1 V +1 03/27/25, 14:02

  12. Benni Mack voted on patch set 5 CR +2 V +2 03/27/25, 14:13

  13. core-ci voted on patch set 5 V +1 03/27/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76466

  14. Benni Mack merged patch set 6 03/27/25, 14:16