Review main Merged

86443[BUGFIX] Use `\Collator` to sort TCA select items

Andreas Kienast CR +2 V +2 Easy +9 −6 updated 10/10/24, 18:58

Commit message

PHP's `intl` package provides a `\Collator` class that allows to compare
unicode strings. The class is now incorporated in `SelectItemProcessor`
used in FormEngine's select elements.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Thomas Hohn +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 10/07/24, 11:17

  2. core-ci voted on patch set 1 V +1 10/07/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67228

  3. Andreas Kienast uploaded patch set 2 V +1 10/07/24, 15:16

  4. core-ci voted on patch set 2 V +1 10/07/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67252

  5. Garvin Hicking voted on patch set 2 CR +1 10/07/24, 18:33

  6. Thomas Hohn voted on patch set 2 CR +1 10/09/24, 07:52

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 10/09/24, 10:21

  8. Benjamin Franzke voted on patch set 2 CR +1 V +1 10/10/24, 17:03

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/10/24, 18:41

  10. Benjamin Franzke merged patch set 3 10/10/24, 18:58