Review main Merged

86446[BUGFIX] Setup: Normalize "no" as input when asking for basic site

Andreas Kienast CR +2 V +2 Easy +9 −0 updated 10/07/24, 16:28

Commit message

The `setup` command asks whether a basic site shall be created when
installing TYPO3. The question implies that it defaults to "no" value,
but fails to accept "no" as input given by the user.

This commit adds a normalizer for that question that converts "no" to an
empty string, having the same effect as stepping through the question by
providing no input at all.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Andreas Kienast uploaded patch set 1 10/07/24, 13:02

  2. Andreas Kienast uploaded patch set 2 10/07/24, 13:03

  3. core-ci voted on patch set 2 V +1 10/07/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67235

  4. Mathias Brodala commented on patch set 2 10/07/24, 13:32

    SetupCommand.php:640

    Why not: strtolower($value) === 'no'
  5. Andreas Kienast commented on patch set 2 10/07/24, 14:16

    SetupCommand.php:640 Reply

    We could do this as well. I got influenced by the ConfirmationQuestion class.
  6. Andreas Kienast uploaded patch set 3 V +1 10/07/24, 14:17

  7. Andreas Kienast commented on patch set 3 10/07/24, 14:17

    SetupCommand.php:640 Reply

    Done
  8. Garvin Hicking voted on patch set 3 CR +1 V +1 10/07/24, 14:24

  9. core-ci voted on patch set 3 V +1 10/07/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67243

  10. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/07/24, 16:26

  11. Benjamin Franzke merged patch set 4 10/07/24, 16:28