Review main Merged

86447[BUGFIX] Have ElementInformationController preview url use correct language

Filipe DA COSTA CR +2 V +2 Easy +5 −0 updated 11/18/24, 10:12

Commit message

If displaying page actions, use the target pages'
sys_language_uid to build the frontend URL.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1723

  1. Filipe DA COSTA uploaded patch set 1 10/07/24, 13:04

  2. core-ci voted on patch set 1 V -1 10/07/24, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67236

  3. core-ci voted on patch set 1 V +1 10/07/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67236

  4. Oli Bartsch commented on patch set 1 10/07/24, 13:45

    ElementInformationController.php:514

    We need to check for the languageField as we can not rely on the field being set to `sys_language_uid`.
  5. Filipe DA COSTA uploaded patch set 2 V +1 10/07/24, 14:53

  6. Filipe DA COSTA commented on patch set 2 10/07/24, 14:56

    ElementInformationController.php:514 Reply

    I've looked around how it's done and found an example in DatabaseRecordList.php, updated the code to match it,
  7. Benni Mack updated the commit message in patch set 3 10/07/24, 14:58

  8. core-ci voted on patch set 3 V +1 10/07/24, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67249

  9. Oliver Hader updated the commit message in patch set 4 V +1 10/18/24, 14:00

  10. Oliver Hader rebased onto patch set 5 10/24/24, 09:43

  11. core-ci voted on patch set 5 V +1 10/24/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68524

  12. Benni Mack commented on patch set 6 V +1 10/25/24, 09:10

    Published edit on patch set 5.
  13. core-ci voted on patch set 6 V +1 10/25/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68598

  14. Benni Mack updated the commit message in patch set 7 V +1 11/15/24, 16:30

  15. Benni Mack voted on patch set 7 CR +1 11/15/24, 16:30

  16. core-ci voted on patch set 7 V +1 11/15/24, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69493

  17. Benni Mack voted on patch set 7 V +1 11/15/24, 18:52

  18. Garvin Hicking commented on patch set 7 11/15/24, 19:00

    Just from a performance standpoint, we perform the whole getRecord again here, when it is fetched at a place from where getRecordActions is called and sets parentRecord already. I wonder if we should besser pass it around rather than fetching possibly 100*100 single DB queries for a record listing of 100 items...? (might be micro optimization so don't let this be blocking)
  19. Benni Mack commented on patch set 7 11/15/24, 20:14

    Reply

    This happens if actually reference an item (let's an image) on 100 pages. And we open a showitem / info popup / modal for this. Then we have a query for each of these pages AND we have a query for each of the rootline (BEgetRootline) below. If it's a performance issue, we might have seen some issues about this already. tbh: We're talking about a minor bugfix here, and having 100 relations to 100 pages, I would expect to use pagination at some point then ;) what I'm saying - yes, let's be sceptical about issues, but at the same time, be graceful when we're talking about bugfixes and actually get them done / in.
  20. Jochen Roth voted on patch set 7 CR +1 V +1 11/18/24, 09:59

  21. Garvin Hicking voted on patch set 7 CR +1 V +1 11/18/24, 10:12

  22. Benni Mack voted on patch set 7 CR +2 V +2 11/18/24, 10:12

  23. Benni Mack merged patch set 8 11/18/24, 10:12