Review main Merged

86451[BUGFIX] Avoid PHP warning in HMENU browse menus

Benni Mack CR +2 V +2 Easy +10 −7 updated 10/10/24, 16:56

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Benni Mack uploaded patch set 1 10/07/24, 14:31

  2. core-ci voted on patch set 1 V +1 10/07/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67246

  3. Benjamin Franzke voted on patch set 1 CR +1 10/07/24, 16:30

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/07/24, 17:39

  5. Oli Bartsch commented on patch set 1 10/07/24, 19:51

    AbstractMenuContentObject.php:993

    We do we check the same value again instead of using a local variable?
  6. Oli Bartsch uploaded patch set 2 CR +1 V +1 10/07/24, 19:56

  7. Oli Bartsch commented on patch set 2 CR +1 V +1 10/07/24, 19:56

    AbstractMenuContentObject.php:993 Reply

    Done
  8. core-ci voted on patch set 2 V +1 10/07/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67285

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 10/08/24, 12:11

  10. Benjamin Franzke voted on patch set 2 CR -1 10/08/24, 12:40

  11. Benjamin Franzke commented on patch set 2 10/08/24, 12:40

    No 11.5 anymore
  12. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 10/08/24, 14:30

  13. Oli Bartsch commented on patch set 3 CR +1 V +1 10/08/24, 14:30

    Reply

    Acknowledged
  14. core-ci voted on patch set 3 V +1 10/08/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67381

  15. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/10/24, 16:48

  16. Benjamin Franzke merged patch set 4 10/10/24, 16:56