Review 13.3 Merged

86456[TASK] Mitigate `PHP 8.4.0-RC1` breaking changes

Stefan Bürk CR +2 V +2 Normal +40 −22 updated 10/07/24, 17:32

Commit message

Note that this change addresses three different issues, which
need to be done in one step, otherwise none of isolated patches
would get a +1 CI verification:

* Alignment for changed `$escape` parameter handling of CSV
  related methods, which must be avoided with PHP versions below
  8.4.0-beta5, but is required as of PHP 8.4.0-RC1.
* This `$escape` issue needs to be addressed directly in
  the `typo3/testing-framework` and thus needs a raised
  dependency directly.
* PHP 8.4.0.0-RC1 also deprecated the `E_STRICT` constant,
  which needs to be addressed directly.

With [1] the `$escape` parameter for the following method calls

* `str_getcsv()`
* `fputcsv()`
* `fgetcsv()`

must be provided as a 1 character long value. Omitting and
using the default value will emit a PHP deprecation [2] warning
as of PHP 8.4.0-RC1, for example:

  str_getcsv(): the $escape parameter must be provided
  as its default value will change

To mitigate this, PHP recommends following:

  It must be passed explicitly either positionally or
  via named arguments.

This change adjusts all occurences (function calls) and ensures
that the `$escape` parameter is explicitly provided via
specifying all parameters up to that position and not
using a `named arguments` approach for easier backporting.

The TYPO3 testing framework also needs to be aligned to
mitigate `fgetcsv()` issues, and is raised in the same
step - otherwise none of these changes would get a green
CI pipeline run.

The following testing-framework updates are adjusted:

* main: simple update `main` pointer
* 12.4: Raise to tag `8.2.2`
* 11.5: Raise to tag `6.16.10`

Used command(s):

> composer update "typo3/testing-framework"

Note that the backport has been squashed with the later partly
revert using integer values instead of adding a own deprecated
constant #105165 for [3][4].

We can not deprecate a constant and use it at the same time.
We basically traded a deprecated constant with a new deprecated
constant. Therefore this intermediate constant (added without being
released yet in #105155) is removed again and replaced by a plain value.

It's too likely that this constant is used by 3rd party code
(or dependencies like typo3/testing-framework), which then makes
it hard to remove this constant again (despite being deprecated).

Also defining an own constant – that looks like an official PHP
constant – into the global space, has caused immediate confusions
which we want to avoid by using a scalar value + comment.

The reason (possible 3rd party extensions that may still trigger
this error) why this is kept (and not just removed) is also added
to all usages now.

[1] https://github.com/php/php-src/pull/15569
[2] https://github.com/php/php-src/blob/ebee8df27ed/UPGRADING#L617-L622
[3] https://github.com/php/php-src/blob/ebee8df27edf7/UPGRADING#L47-L49
[4] https://github.com/php/php-src/pull/13053

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/07/24, 16:03

  2. core-ci voted on patch set 1 V +1 10/07/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67260

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/07/24, 16:30

  4. Oliver Hader voted on patch set 1 CR +1 V +1 10/07/24, 17:24

  5. Oliver Hader voted on patch set 1 CR +2 V +2 10/07/24, 17:31

  6. Oliver Hader merged patch set 2 10/07/24, 17:32