Review 12.4 Merged

86464[TASK] Resolve all phpstan errors in CorrelationId

Benjamin Franzke CR +2 V +2 Easy +8 −37 updated 10/08/24, 11:18

Commit message

* Drop unneeded annoated return types that lead to
   errors

 * The aspects array-key is always set because the
   capture is not nested and filled in any case.
   That means: If preg_match was successfull
   (which is checked before), aspects have been found as well.

Executed commands:

  composer require --dev phpstan/phpstan:^1.12.6
  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Benjamin Franzke uploaded patch set 1 10/08/24, 02:17

  2. core-ci voted on patch set 1 V -1 10/08/24, 02:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67294

  3. Benjamin Franzke uploaded patch set 2 V -1 10/08/24, 02:32

  4. Benjamin Franzke updated the commit message in patch set 3 10/08/24, 02:34

  5. core-ci voted on patch set 3 V -1 10/08/24, 02:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67298

  6. Benjamin Franzke uploaded patch set 4 V -1 10/08/24, 02:48

  7. Benjamin Franzke voted on patch set 4 CR -2 10/08/24, 02:49

  8. core-ci voted on patch set 4 V +1 10/08/24, 02:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67299

  9. Benjamin Franzke uploaded patch set 5 V +1 10/08/24, 10:30

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. core-ci voted on patch set 5 V +1 10/08/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67365

  11. Stefan Bürk voted on patch set 5 CR +2 V +2 10/08/24, 11:18

  12. Stefan Bürk merged patch set 6 10/08/24, 11:18