Review 12.4 Merged

86466[BUGFIX] Fix undefined array key table in ContextMenuController

Benjamin Franzke CR +2 V +2 Easy +33 −8 updated 04/11/25, 14:01

Commit message

Ensure that the ContextMenuController checks if the required
table and uid query parameters are provided and return a 400
if not.

Also make sure the frontend part throws an error if invalid
markup is used that would lead to the mentioned 400 response.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 812

  1. Benjamin Franzke uploaded patch set 1 10/08/24, 05:05

  2. core-ci voted on patch set 1 V +1 10/08/24, 05:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67311

  3. Benjamin Franzke uploaded patch set 2 V +1 10/08/24, 07:10

  4. core-ci voted on patch set 2 V +1 10/08/24, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67325

  5. Oliver Hader updated the commit message in patch set 3 V +1 10/18/24, 14:06

  6. Andreas Kienast uploaded patch set 4 04/11/25, 12:39

  7. Andreas Kienast marked it ready for review 04/11/25, 12:39

  8. Andreas Kienast uploaded patch set 5 04/11/25, 12:40

  9. core-ci voted on patch set 4 V +1 04/11/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77534

  10. core-ci voted on patch set 5 V +1 04/11/25, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77535

  11. Benni Mack voted on patch set 5 CR +2 V +2 04/11/25, 14:01

  12. Benni Mack merged patch set 6 04/11/25, 14:01