Review 11.5 Abandoned

86467[BUGFIX] Fix undefined array key table in ContextMenuController

Benjamin Franzke CR 0 V 0 Easy +12 −2 updated 10/08/24, 07:06

Commit message

This patch ensures that the `handleContextMenuEvent` method
in the `context-menu` throws an error if no contextmenuTable
is provided. And thus no faulty AJAX request is sent to the
backend. Additionally, if no table or identifier are provided,
the PHP code will return an empty JSON response with status 400.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 10/08/24, 05:41

  2. Benjamin Franzke marked it work in progress 10/08/24, 05:41

  3. core-ci voted on patch set 1 V +1 10/08/24, 05:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67314

  4. Benjamin Franzke abandoned the change 10/08/24, 07:06

    not a priority fix (requires invalid user markup)