Review main Merged

86470[TASK] Extract sys_note delete button into Lit component

Andreas Kienast CR +2 V +2 Normal +146 −15 updated 10/08/24, 07:55

Commit message

The delete button for sys_notes rendered in the record list is currently
nested in a form tag, breaking the user interface. Since this requires a
DataHandler call, the button is converted to a Lit component that
invokes the `AjaxDataHandler` module.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 914

  1. Andreas Kienast uploaded patch set 1 10/08/24, 07:22

  2. Andreas Kienast uploaded patch set 2 10/08/24, 07:23

  3. core-ci voted on patch set 1 V -1 10/08/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67327

  4. Andreas Kienast uploaded patch set 3 10/08/24, 07:31

  5. core-ci voted on patch set 2 V -1 10/08/24, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67328

  6. core-ci voted on patch set 3 V +1 10/08/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67330

  7. Andreas Kienast uploaded patch set 4 V +1 10/08/24, 07:39

  8. Oli Bartsch uploaded patch set 5 10/08/24, 07:42

  9. Oli Bartsch voted on patch set 5 CR +1 V +1 10/08/24, 07:42

  10. Benjamin Kott voted on patch set 5 CR +1 V +1 10/08/24, 07:43

  11. core-ci voted on patch set 4 V +1 10/08/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67335

  12. core-ci voted on patch set 5 V +1 10/08/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67336

  13. Andreas Kienast voted on patch set 5 CR +2 V +2 10/08/24, 07:55

  14. Andreas Kienast merged patch set 6 10/08/24, 07:55