Review 12.4 Merged

86472[TASK] Mitigate DNS lookup issues in started containers

Stefan Bürk CR +2 V +2 Easy +4 −0 updated 10/07/24, 17:58

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk commented on patch set 1 10/07/24, 17:19

    Cherry Picked from branch 13.3.
  2. core-ci voted on patch set 1 V -1 10/07/24, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67268

  3. Benjamin Franzke commented on patch set 1 10/07/24, 17:45

    Looks like it hang during `npm install` this time. ``` Running "exec:npm-install" (exec) task >> npm error Exit handler never called! >> npm error This is an error with npm itself. Please report this error at: >> npm error <https://github.com/npm/cli/issues>; >> npm error A complete log of this run can be found in: /builds/typo3/CI/cms/.cache/.npm/_logs/2024-10-07T17_33_38_924Z-debug-0.log ``` So a host entry for npmjs.com would probably be "needed" as well. Restarting now…
  4. core-ci voted on patch set 1 V +1 10/07/24, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67268

  5. Stefan Bürk commented on patch set 1 10/07/24, 17:47

    Reply

    Will prepare a followup change for the full chain, don't want to mix that now inbetween.
  6. Stefan Bürk voted on patch set 1 CR +2 V +2 10/07/24, 17:57

  7. Stefan Bürk merged patch set 2 10/07/24, 17:58