Review 12.4 Merged

86477[BUGFIX] Allow dumping files larger than allowed memory size

Andreas Kienast CR +2 V +2 Easy +3 −0 updated 10/09/24, 05:52

Commit message

The `SelfEmittableLazyOpenStream` class used by FileDumpController
uses `readfile` which is meant to be a performant way to send
files to the webserver (implemented by PHP in C) and does not
count as runtime memory usage (memory_limit) if the output is
unbuffered.

Make sure to clear any output buffers before emitting self emittable
streams in order for PHP to be able to send the files without copying
the contents into a temporary buffer (counting towards memory limit).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 10/09/24, 05:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/09/24, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67411

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 10/09/24, 05:52

  4. Andreas Kienast merged patch set 2 10/09/24, 05:52