Review 12.4 Merged

86479[BUGFIX] Prevent undefined array key access in 'removeTags' parsing

Garvin Hicking CR +2 V +2 Normal +116 −15 updated 10/11/24, 07:09

Commit message

This patch addresses a regression introduced in the TypoScript
config parsing of the 'removeTags' processing. When 'removeTags'
was set as a string (not an array), a PHP "Undefined array
key access" warning occurred.

Tests are added to parse TSconfig variant for strings and
arrays, in addition to the existing YAML-based tests.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Garvin Hicking commented on patch set 1 10/11/24, 07:03

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/11/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67553

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 10/11/24, 07:08

  4. Garvin Hicking merged patch set 2 10/11/24, 07:09