Review main Merged

86493[TASK] Declare TypoScriptFrontendController deprecated

Christian Kuhn CR +2 V +2 Normal +100 −40 updated 04/19/25, 16:43

Commit message

We worked hard on TypoScriptFrontendController in TYPO3 v13
leaving mainly internal code and usages. A couple of details
are still left open, and we can't tackle them in v13 anymore
due to time constraints. The most notable area is the main
content generation trigger and the *_INT processing.

However, all non-internal usages by extensions can be
substituted. Usually by using new attributes of the request.

The goal is still to get rid of TypoScriptFrontendController
in TYPO3 v14. The patch prepares this by declaring
TypoScriptFrontendController fully deprecated, even though
with some left over internal usages. TYPO3 v14 will see a
few preparation patches to reach this goal.

The patch polishes a ReST file from 13.0 to add some more
"Use this instead" information, and adds a new ReST file
declaring TypoScriptFrontendController and $GLOBALS['TSFE']
deprecated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 5

Review log 1215

  1. Christian Kuhn uploaded patch set 1 10/08/24, 08:33

  2. core-ci voted on patch set 1 V +1 10/08/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67342

  3. Oli Bartsch uploaded patch set 2 V +1 10/08/24, 09:02

  4. Oli Bartsch voted on patch set 2 CR +1 V +1 10/08/24, 09:02

  5. core-ci voted on patch set 2 V +1 10/08/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67355

  6. Andreas Kienast commented on patch set 2 10/08/24, 09:37

    "generation", I assume?
  7. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 10/08/24, 09:45

  8. Christian Kuhn commented on patch set 3 10/08/24, 09:45

    Reply

    Done
  9. Oli Bartsch voted on patch set 3 CR +1 V +1 10/08/24, 09:47

  10. core-ci voted on patch set 3 V +1 10/08/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67361

  11. Stefan Bürk voted on patch set 3 CR +1 V +1 10/08/24, 10:09

  12. Andreas Kienast voted on patch set 3 CR +1 10/08/24, 10:14

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 10/08/24, 11:28

  14. Christian Kuhn merged patch set 4 10/08/24, 11:28

  15. Lina Wolf commented on patch set 4 04/19/25, 16:43

    does that mean https://docs.typo3.org/permalink/t3tsref:confval-data-tsfe is also deprecated and if so what it the migration path? What happens to all these mentioning s like with register? https://docs.typo3.org/permalink/t3tsref:data-type-gettext-register Are they now stored in the request? Are the conditions now deprecated? https://docs.typo3.org/permalink/t3tsref:condition-function-gettsfe