Review main Merged

86501[SECURITY] Show only explicitly configured page tree information

Oliver Hader CR +2 V +2 Normal +70 −20 updated 10/08/24, 12:51

Commit message

Backend users were able see page tree items without having access:
- in case no DB mounts were configured for a particular user
  and page permissions configured to allow "everybody"
- in case DB mounts were pointing to pages, but actually not having
  any permission configured for these pages (user/group/everybody)

It was not possible to manipulate any of the affected pages.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 5

Review log 67

  1. Oliver Hader uploaded patch set 1 10/08/24, 08:35

  2. Oliver Hader commented on patch set 1 CR +2 V +2 10/08/24, 08:35

    Auto-approved
  3. Oliver Hader merged patch set 2 10/08/24, 08:35

  4. core-ci voted on patch set 1 V +1 10/08/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67350

  5. Simon Schaufelberger commented on patch set 2 10/08/24, 09:42

    PageTreeRepository.php:175

    @oliver.hader@typo3.org that annotation is wrong. it should be array|null
  6. Oliver Hader commented on patch set 2 10/08/24, 12:05

    PageTreeRepository.php:175 Reply

    Please create a patch-set in case you think it's wrong. Thx!
  7. Simon Schaufelberger commented on patch set 2 10/08/24, 12:51

    PageTreeRepository.php:175 Reply

    I did but it got rejected.