Review main Abandoned

86502[BUGFIX] Delete files in recycler folders recursively

Oli Bartsch CR -1 V 0 Easy +1 −3 updated 10/06/26, 08:22

Commit message

The RecyclerGarbageCollectionTask does now
properly delete all files in all recycler
folders of all found storages as described
in the class documentation (PHPDoc).

Previously, the task only took recycler
folders on first level into account and
also only the first occurrence on each
storage.

Review

  • Code review CR -1
    • Benni Mack -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Oli Bartsch uploaded patch set 1 10/08/24, 08:46

  2. core-ci voted on patch set 1 V +1 10/08/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67351

  3. Oli Bartsch commented on patch set 1 V -1 10/08/24, 17:16

    Need to check sth.
  4. Oliver Hader updated the commit message in patch set 2 V +1 10/18/24, 14:00

  5. core-ci voted on patch set 2 V +1 10/18/24, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68099

  6. Simon Schaufelberger rebased onto patch set 3 V +1 12/17/24, 18:45

  7. Simon Schaufelberger commented on patch set 3 12/17/24, 18:46

    Reply

    are you done?
  8. Benni Mack voted on patch set 3 CR +1 12/17/24, 18:50

  9. core-ci voted on patch set 3 V +1 12/17/24, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71310

  10. Oli Bartsch commented on patch set 3 12/17/24, 20:01

    Reply Unresolved

    Thank you for following up on this. Unfortunately, I haven’t had the time to revisit the issue yet. As far as I recall, the main problem was related to nested folders causing timeouts, which would require further investigation. At the moment, I’m focused on a couple of high-priority tasks, which is one reason for my limited availability. I’m unsure when I’ll be able to address this, but if you’re interested, I’d be happy if you could take over and work on a resolution.
  11. Benni Mack commented on patch set 3 CR -1 03/26/25, 11:26

    I suggest to do only main + v13
  12. Benni Mack marked it work in progress 03/26/25, 11:26

  13. Oli Bartsch abandoned the change 10/06/26, 08:22