Review main Abandoned

86510[BUGFIX] Fix incorrect doctype annotation

Simon Schaufelberger CR 0 V 0 Easy +1 −1 updated 10/08/24, 10:12

Commit message

Use array|null instead of ?array in docblock

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 56

  1. Simon Schaufelberger uploaded patch set 1 10/08/24, 09:49

  2. Andreas Kienast commented on patch set 1 CR -1 10/08/24, 09:54

    Why is this incorrect? What does fail now?
  3. core-ci voted on patch set 1 V +1 10/08/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67362

  4. Frank Nägler commented on patch set 1 CR -1 10/08/24, 09:55

    That is the same, no need for a bugfix.
  5. Benjamin Franzke commented on patch set 1 CR -2 10/08/24, 09:57

    I don't like phpstorm driven development.
  6. Simon Schaufelberger abandoned the change 10/08/24, 10:12