Review main Merged

86519[TASK] Remove "visible fields" functional tests

Christian Kuhn CR +2 V +2 Expert +0 −1890 updated 10/08/24, 15:24

Commit message

Remove a bunch of functional tests that essentially
test TCA configuration:

* The tests add no crucial value from a functional
  test point of view since they don't test code but
  configuration.
* These tests have been introduced to enforce consistency
  within BE. This is a UX thing that should not be tested
  on a functional test base level, if at all.
* FormTestService is problematic from a maintenance
  point of view and needs continious changes since
  dependencies can not be handled in a good way.
* The tests are doomed to be inconsistent since they will
  never catch new fields that may have been added to
  TCA tables over time.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 26

Show 6 more files

Review log 911

  1. Christian Kuhn uploaded patch set 1 10/08/24, 14:39

  2. core-ci voted on patch set 1 V +1 10/08/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67382

  3. Christian Kuhn uploaded patch set 2 V +1 10/08/24, 14:57

  4. Stefan Bürk updated the commit message in patch set 3 10/08/24, 15:00

  5. Christian Kuhn updated the commit message in patch set 4 10/08/24, 15:00

  6. Christian Kuhn updated the commit message in patch set 5 10/08/24, 15:02

  7. core-ci voted on patch set 5 V +1 10/08/24, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67387

  8. Garvin Hicking commented on patch set 5 CR +1 V +1 10/08/24, 15:15

    Adieu
  9. Stefan Bürk voted on patch set 5 CR +1 V +1 10/08/24, 15:18

  10. Christian Kuhn commented on patch set 5 CR +2 V +2 10/08/24, 15:19

    This is of course a pre-patch to something else again, preventing me to mess around with FormTestService again. Will merge quickly now.
  11. Christian Kuhn merged patch set 6 10/08/24, 15:24