Review main Merged

86520[TASK] Always get FormEngine NodeFactory injected

Christian Kuhn CR +2 V +2 Normal +42 −74 updated 10/08/24, 19:20

Commit message

Inject NodeFactory in a series of missing places instead
of retrieving an instance via GU::makeInstance().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 813

  1. Christian Kuhn uploaded patch set 1 10/08/24, 15:45

  2. core-ci voted on patch set 1 V -1 10/08/24, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67389

  3. core-ci voted on patch set 1 V +1 10/08/24, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67389

  4. Christian Kuhn uploaded patch set 2 V +1 10/08/24, 16:02

  5. core-ci voted on patch set 2 V -1 10/08/24, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67390

  6. Christian Kuhn updated the commit message in patch set 3 V -1 10/08/24, 16:32

  7. core-ci voted on patch set 2 V +1 10/08/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67390

  8. core-ci voted on patch set 3 V +1 10/08/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67394

  9. Oli Bartsch voted on patch set 3 CR +1 V +1 10/08/24, 17:26

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 10/08/24, 17:44

  11. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/08/24, 18:12

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 10/08/24, 19:19

  13. Christian Kuhn merged patch set 4 10/08/24, 19:20