86521[BUGFIX] Fix pagetree subtree expansion in search mode
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1519
-
Benjamin Franzke uploaded patch set 1 10/08/24, 16:04
-
core-ci voted on patch set 1 V -1 10/08/24, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67391
-
Oliver Hader commented on patch set 1 10/08/24, 16:54
-
Benjamin Franzke uploaded patch set 2
V -110/09/24, 06:29 -
core-ci voted on patch set 2 V +1 10/09/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67412
-
Benjamin Franzke commented on patch set 2 10/09/24, 06:38
TreeController.php:411ReplyI'm not sure I get this right: That means you propose to drop the following condition? ``` if ($depth >= $this->levelsToFetch) { $page = $this->pageTreeRepository->getTreeLevels($page, 1); } ``` This was added together with ` || $this->getPageTreeRepository()->hasChildren($pageId)` in https://review.typo3.org/c/Packages/TYPO3.CMS/+/65208/27/typo3/sysext/backend/Classes/Controller/Page/TreeController.php We need to remember: This codepath applied to non-search mode (as searchmode sets `levelsToFetch` to 999 which basically is a opt-out of this condition). To my understanding that'd introduce a new bug on loading the the-filtered pagetree (this codepath is actively used in that case). -
Oliver Hader uploaded patch set 3
V +110/09/24, 07:49 -
core-ci voted on patch set 3 V -1 10/09/24, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67414
-
Benjamin Franzke uploaded patch set 4
V -110/09/24, 08:12 -
Benjamin Franzke commented on patch set 4 10/09/24, 08:12
TreeController.php:411Replyas discussed, we'll keep this as-before for now. -
core-ci voted on patch set 4 V +1 10/09/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67416
-
Oliver Hader voted on patch set 4 CR +1 10/09/24, 08:55
-
Andreas Kienast voted on patch set 4 CR +1 10/09/24, 11:19
-
Andreas Kienast voted on patch set 4 V +1 10/09/24, 11:55
-
Oliver Hader voted on patch set 4 V +1 10/09/24, 20:55
-
Stefan Bürk voted on patch set 4 CR +1 10/10/24, 05:55
-
Stefan Bürk voted on patch set 4 V +1 10/10/24, 06:24
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 10/10/24, 07:04
-
Benjamin Franzke merged patch set 5 10/10/24, 07:04
TreeController.php:411